Page MenuHome
Differential D3499

Ghost: Fix F12 render on windows.
ClosedPublic
Actions

Authored by Ray Molenkamp (LazyDodo) on Jun 23 2018, 5:23 PM.

Details

Reviewers
Germano Cavalcante (mano-wii)
Clément Foucault (fclem)
Commits
rBS2fa231a86b41: Ghost: Fix F12 render on windows.
rB2fa231a86b41: Ghost: Fix F12 render on windows.
Summary

createOffscreenContext left the new context bound to the calling thread, causing a race condition with the background thread doing the actual rendering. see T55555 for a more detailed description of the problem.

Diff Detail

Repository
rB Blender
Branch
b28_f12_fix (branched from blender2.8)
Build Status
Buildable 1776
Build 1776: arc lint + arc unit

Event Timeline

Ray Molenkamp (LazyDodo) created this revision.Jun 23 2018, 5:23 PM
Ray Molenkamp (LazyDodo) added reviewers: Germano Cavalcante (mano-wii), Clément Foucault (fclem).Jun 23 2018, 5:24 PM
Ray Molenkamp (LazyDodo) updated this revision to Diff 11300.Jun 23 2018, 5:29 PM
  • Fix silly mistake.
Clément Foucault (fclem) accepted this revision.Jun 23 2018, 5:39 PM

Looks good to me.

This revision is now accepted and ready to land.Jun 23 2018, 5:39 PM
Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).Jun 23 2018, 6:18 PM

I have tested the patch in windows 10 and the error is fixed.

Closed by commit rB2fa231a86b41: Ghost: Fix F12 render on windows. (authored by Ray Molenkamp (LazyDodo)). · Explain WhyJun 23 2018, 7:38 PM
This revision was automatically updated to reflect the committed changes.
Ray Molenkamp (LazyDodo) mentioned this in T55555: Crash as soon as press material button in properties panel.Jun 23 2018, 7:38 PM

Revision Contents
Changeset List

PathSize
intern/
ghost/
intern/
12 lines

Diff 11300

View Options

intern/ghost/intern/GHOST_SystemWin32.cpp

Loading...