Page MenuHome
Differential D3503

Cycles Voronoi Noise : Update original patch to 2.8
ClosedPublic
Actions

Authored by Charlie Jolly (charlie) on Jun 25 2018, 8:00 PM.

Details

Reviewers
None
Group Reviewers
Cycles
Commits
rC079150c81102: add voronoi features and distance settings from Blender.
rBS83a4e1aaf9d1: Cycles: add voronoi features and distance settings from Blender.
rB83a4e1aaf9d1: Cycles: add voronoi features and distance settings from Blender.

Diff Detail

Repository
rB Blender

Event Timeline

Charlie Jolly (charlie) created this revision.Jun 25 2018, 8:00 PM
Charlie Jolly (charlie) mentioned this in D1463: Expand Voronoi node functionality in Cycles.Jun 25 2018, 8:01 PM

Update D1463 to Blender 2.8

Charlie Jolly (charlie) retitled this revision from Update patch to 2.8 to Cycles Voronoi Noise : Update original patch to 2.8.Jun 25 2018, 10:33 PM
Charlie Jolly (charlie) added a reviewer: Cycles.
Charlie Jolly (charlie) added projects: Cycles, BF Blender: 2.8.
Charlie Jolly (charlie) updated this revision to Diff 11380.Jul 10 2018, 2:49 PM
  • Merge branch 'blender2.8' of git://git.blender.org/blender into arcpatch-D3503
  • Add OSL
This revision was not accepted when it landed; it landed in state Needs Review.Jul 15 2018, 12:46 AM
Closed by commit rB83a4e1aaf9d1: Cycles: add voronoi features and distance settings from Blender. (authored by Charlie Jolly (charlie), committed by Brecht Van Lommel (brecht)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).Jul 15 2018, 12:52 AM

Committed with changes:

  • Refactor to avoid code duplication and CUDA performance regression
  • Match code style
  • Hide Exponent socket when not used
  • Eliminate Minkowski 1/2 and 4, these are just different exponent values
  • Fix GLSL shader to at least compile, but support for these new setting is still missing in viewport/Eeevee
intern/cycles/kernel/shaders/node_voronoi_texture.osl
121–122

Note this is not needed, OSL string comparisons are fast and in this constant folded away entirely.

Bartosz Moniewski (monio) awarded a token.Jul 15 2018, 3:53 PM
Michel Anders (varkenvarken) added a subscriber: Michel Anders (varkenvarken).Sep 8 2018, 9:45 PM

Revision Contents
Changeset List

PathSize
intern/
cycles/
blender/
2 lines
kernel/
shaders/
122 lines
svm/
15 lines
156 lines
render/
4 lines
39 lines
util/
5 lines
source/
blender/
editors/
space_node/
2 lines
gpu/
shaders/
2 lines
makesdna/
19 lines
makesrna/
intern/
46 lines
nodes/
shader/
nodes/
21 lines

Diff 11418

View Options

intern/cycles/blender/blender_shader.cpp

Loading...
View Options

intern/cycles/kernel/shaders/node_voronoi_texture.osl

Loading...
View Options

intern/cycles/kernel/svm/svm_types.h

Loading...
View Options

intern/cycles/kernel/svm/svm_voronoi.h

Loading...
View Options

intern/cycles/render/nodes.h

Loading...
View Options

intern/cycles/render/nodes.cpp

Loading...
View Options

intern/cycles/util/util_math_float3.h

Loading...
View Options

source/blender/editors/space_node/drawnode.c

Loading...
View Options

source/blender/gpu/shaders/gpu_shader_material.glsl

Loading...
View Options

source/blender/makesdna/DNA_node_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_nodetree.c

Loading...
View Options

source/blender/nodes/shader/nodes/node_shader_tex_voronoi.c

Loading...