Page MenuHome
Differential D3518

Fix T55542: BAT doesn't pack smoke cache
AbandonedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jul 4 2018, 1:26 PM.

Details

Reviewers
Sybren A. Stüvel (sybren)

Diff Detail

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Jul 4 2018, 1:26 PM
Philipp Oeser (lichtwerk) mentioned this in T55542: BAT doesn't pack smoke cache.
Sybren A. Stüvel (sybren) added a comment.Jul 4 2018, 2:33 PM

Looks nice, although it's missing a unit test for the tracer and a unit test for the packer.

blender_asset_tracer/trace/modifier_walkers.py
212

Since the only difference between the calls is the extension, it's probably better to just have a little dict lookup, like:

extensions = {
  cdefs.PTCACHE_FILE_PTCACHE: cdefs.PTCACHE_EXT,
  cdefs.PTCACHE_FILE_OPENVDB: cdefs.PTCACHE_EXT_VDB
}
Philipp Oeser (lichtwerk) updated this revision to Diff 11359.Jul 5 2018, 1:29 PM

add unittests
use dict lookup for cache extension

Philipp Oeser (lichtwerk) marked an inline comment as done.Jul 5 2018, 1:38 PM
Philipp Oeser (lichtwerk) added inline comments.
tests/test_tracer.py
184 ↗(On Diff #11359)

noticed path can be longer then 64 [if no name for the cache is provided, since hex blows it up]

Sybren A. Stüvel (sybren) accepted this revision.EditedJul 5 2018, 4:02 PM

lgtm, but maybe reduce the number of frames to 10.

This revision is now accepted and ready to land.Jul 5 2018, 4:02 PM
Philipp Oeser (lichtwerk) abandoned this revision.Jul 6 2018, 11:54 AM

commited with less (10) cache frames in tests
rBAST4e1c2d1bbb72da1fc48134fb3bc46af75aec34fb

Revision Contents
Changeset List

PathSize
blender_asset_tracer/
4 lines
trace/
31 lines

Diff 11346

View Options

blender_asset_tracer/cdefs.py

Loading...
View Options

blender_asset_tracer/trace/modifier_walkers.py

Loading...