FIX Windows stuck in touch mode on some pen displays
ClosedPublic
Actions

Authored by Colby Klein (shakesoda) on Aug 1 2018, 2:37 PM.

Details

Reviewers

Joshua Leung (aligorith)
Antonio Vazquez (antoniov)
Brecht Van Lommel (brecht)

Commits

rBS31c99c0c4e4d: Fix pen tablet stuck on Windows for some non-Wacom tablets.
rB31c99c0c4e4d: Fix pen tablet stuck on Windows for some non-Wacom tablets.

Summary

On some tablets, WinTab doesn't seem to behave properly unless you reactivate the context on WM_ACTIVATE, and initialize context disabled (enable after open instead). Tested good with my Monoprice MP22 (Parblo Coast22) on Windows 10. Doesn't seem to affect Wacom. Formerly marked for T55589, but testing shows this is a separate fix.

Diff Detail

Repository: rB Blender

Event Timeline

Colby Klein (shakesoda) created this revision.Aug 1 2018, 2:37 PM

Ray Molenkamp (LazyDodo) added a reviewer: Joshua Leung (aligorith).Aug 1 2018, 2:50 PM

Ray Molenkamp (LazyDodo) mentioned this in T55589: Microsoft Surface pens does not send first events when moves.Aug 1 2018, 4:24 PM

Brecht Van Lommel (brecht) added a reviewer: Antonio Vazquez (antoniov).Aug 1 2018, 7:46 PM

I'm going to prepare a test in Surface of the patch.

Colby Klein (shakesoda) retitled this revision from FIX T55589 to FIX Windows stuck in touch mode on some pen displays.Aug 6 2018, 1:29 PM

Colby Klein (shakesoda) edited the summary of this revision. (Show Details)

Reading the spec and the code, it looks correct to me. My only concern is that in other places we use wintab functions we always check if they aren't NULL, we could do the same here just to be entirely sure.

@Antonio Vazquez (antoniov), in your tests, did it break anything? If not seems like we should just commit this even if it doesn't solve the surface issue.

This revision now requires changes to proceed.Aug 8 2018, 6:57 PM

we need ask to @Daniel Martinez Lara (pepeland) . Daniel, the test you did in surface did break anything in wacom or other windows computers?

@Brecht Van Lommel (brecht) thanks for reviewing, fixed missing NULL checks.

Accepting the code, we can commit if the tests go well.

This revision is now accepted and ready to land.Aug 8 2018, 8:29 PM

In D3573#82426, @Antonio Vazquez (antoniov) wrote:

we need ask to @Daniel Martinez Lara (pepeland) . Daniel, the test you did in surface did break anything in wacom or other windows computers?

In my test the wacom still working properly in my surface pro 2

been a while since tested good and no reports of issues, can this be merged?

Closed by commit rB31c99c0c4e4d: Fix pen tablet stuck on Windows for some non-Wacom tablets. (authored by Colby Klein (shakesoda), committed by Brecht Van Lommel (brecht)). · Explain WhyAug 26 2018, 11:59 PM

This revision was automatically updated to reflect the committed changes.