Page MenuHome
Differential D3587

Python: Add support for @ infix operator matrix multiplication
ClosedPublic
Actions

Authored by Andrew Hale (trumanblending) on Aug 8 2018, 5:09 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Commits
rBSaa5a96430ea0: Python: Add support for @ infix operator matrix multiplication
rBaa5a96430ea0: Python: Add support for @ infix operator matrix multiplication
Summary

This differential revision implements the code for T56276

Diff Detail

Repository
rB Blender

Event Timeline

Andrew Hale (trumanblending) created this revision.Aug 8 2018, 5:09 PM
Campbell Barton (campbellbarton) requested changes to this revision.EditedAug 9 2018, 12:02 AM

LGTM, notes:

  • Committed BLI changes to master.
  • As you stated, not sure quat * quat is all that useful, although quat * flaot is, so we could support it for completeness.
  • For final patch, nb_inplace_matrix_multiply should be supported (a @= b). As far as I can see this is only remaining TODO.
This revision now requires changes to proceed.Aug 9 2018, 12:02 AM
Andrew Hale (trumanblending) mentioned this in T56276: Python: Add support for @ infix operator matrix multiplication.Aug 9 2018, 12:55 PM
Andrew Hale (trumanblending) updated this revision to Diff 11525.Aug 9 2018, 1:10 PM
  • Add math function to copy arbitrary length array
  • Implement inplace multiplication for matrices
  • Implement inplace multiplication for quaternions
  • Cleanup: type checking
  • Implement inplace quaternion multiplication
Campbell Barton (campbellbarton) added a comment.Aug 10 2018, 10:13 AM

LGTM, final-final TODO is to bring tests back :), see tests/python/bl_pyapi_mathutils.py

Campbell Barton (campbellbarton) accepted this revision.Aug 10 2018, 10:13 AM
This revision is now accepted and ready to land.Aug 10 2018, 10:13 AM
Closed by commit rBaa5a96430ea0: Python: Add support for @ infix operator matrix multiplication (authored by Andrew Hale (trumanblending)). · Explain WhyAug 10 2018, 3:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
python/
mathutils/
195 lines
147 lines
166 lines
tests/
python/
102 lines

Diff 11533

View Options

source/blender/python/mathutils/mathutils_Matrix.c

Loading...
View Options

source/blender/python/mathutils/mathutils_Quaternion.c

Loading...
View Options

source/blender/python/mathutils/mathutils_Vector.c

Loading...
View Options

tests/python/bl_pyapi_mathutils.py

Loading...