Page MenuHome
Differential D3590

Python: Cleanup Noise Module
ClosedPublic
Actions

Authored by Andrew Hale (trumanblending) on Aug 9 2018, 2:39 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Commits
rBSdade2b754871: Python: Cleanup Noise Module
rBdade2b754871: Python: Cleanup Noise Module
Summary

Implements the changes detailed in T56281

Diff Detail

Repository
rB Blender

Event Timeline

Andrew Hale (trumanblending) created this revision.Aug 9 2018, 2:39 PM
Andrew Hale (trumanblending) updated this revision to Diff 11604.Aug 16 2018, 2:31 PM

Updated noise module revision

  • Noise: add back random vector
Campbell Barton (campbellbarton) requested changes to this revision.EditedAug 22 2018, 9:09 AM

Generally LGTM, besides move to PyC_FlagSet to avoid large conditional blocks for each string/int lookup.

source/blender/python/mathutils/mathutils_noise.c
213–242

This can use PyC_FlagSet for simple string/int mappings.

258–278

See above.

This revision now requires changes to proceed.Aug 22 2018, 9:09 AM
Andrew Hale (trumanblending) updated this revision to Diff 11646.Aug 22 2018, 11:38 AM
  • Add back random_vector
  • Correct random_vector docs
  • Correct random_vector args parsing string
  • Use PyC_FlagSets instead of custom functions
  • Add default value macros and checks
  • Fix keyword naming for voronoi
  • Fix docs: enumerator default value
Campbell Barton (campbellbarton) accepted this revision.Aug 22 2018, 2:44 PM

Generally fine, minor change noted inline.

source/blender/python/mathutils/mathutils_noise.c
465

Would initialize to DEFAULT_NOISE_TYPE, then you dont need to do this later on.

555

Again here.

This revision is now accepted and ready to land.Aug 22 2018, 2:44 PM
Campbell Barton (campbellbarton) added inline comments.Aug 22 2018, 2:45 PM
source/blender/python/mathutils/mathutils_noise.c
208–234

These can be static

Closed by commit rBdade2b754871: Python: Cleanup Noise Module (authored by Andrew Hale (trumanblending)). · Explain WhyAug 22 2018, 3:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
python/
mathutils/
489 lines

Diff 11649

View Options

source/blender/python/mathutils/mathutils_noise.c

Loading...