Page MenuHome
Differential D3639

Fix T56500: Origin to geometry crashes on armature
ClosedPublic
Actions

Authored by Dalai Felinto (dfelinto) on Aug 22 2018, 10:04 PM.

Details

Reviewers
Sergey Sharybin (sergey)

Diff Detail

Repository
rB Blender
Branch
temp-fix-crash-origin (branched from blender2.8)
Build Status
Buildable 1946
Build 1946: arc lint + arc unit

Event Timeline

Dalai Felinto (dfelinto) created this revision.Aug 22 2018, 10:04 PM
Dalai Felinto (dfelinto) mentioned this in T56500: Origin to geometry, to cursor, to center of mass, etc with bones make Blender crashing.Aug 22 2018, 10:05 PM
Sergey Sharybin (sergey) accepted this revision.Aug 23 2018, 2:58 PM

LGTM.

While you're on this, mind batch (no pun intended!) add verb to batch_cache_dirty family of names? Maybe something like batch_cache_tag_dirty or batch_cache_dirty_tag. Just to make it obvious if it's an action or query.

This revision is now accepted and ready to land.Aug 23 2018, 2:58 PM
Brecht Van Lommel (brecht) closed this revision.Apr 25 2019, 2:38 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

Committed in rB25c918196ce6: Fix T56500: Origin to geometry crashes on armature.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
2 lines
intern/
18 lines
editors/
object/
2 lines

Diff 11655

View Options

source/blender/blenkernel/BKE_object.h

Loading...
View Options

source/blender/blenkernel/intern/object_update.c

Loading...
View Options

source/blender/editors/object/object_transform.c

Loading...