Differential D3655

Cloth: componentized forces
ClosedPublic
Actions

Authored by Luca Rood (LucaRood) on Aug 28 2018, 6:40 PM.

Tags

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)
Alexander Gavrilov (angavrilov)
Lukas Tönne (lukastoenne)

Commits

rBSe3d31b8dfbdc: Cloth: Componentize forces
rBe3d31b8dfbdc: Cloth: Componentize forces

Summary

This separates cloth stiffness and damping forces into tension, compression, and shearing components, allowing more control over the cloth behavior.

This also adds a bending model selector (although the new bending model itself is not implemented in this patch). This is because some of the features implemented here only make sense within the new bending model, while the old model is kept for compatibility.

This patch makes only non-breaking changes, and thus maintains full compatibility with existing simulations.

Diff Detail

Repository: rB Blender

Event Timeline

Luca Rood (LucaRood) created this revision.Aug 28 2018, 6:40 PM

Luca Rood (LucaRood) mentioned this in T56596: Cloth improvements in 2.8.

Seems generally fine, minor comments.

source/blender/makesdna/DNA_cloth_types.h
61	Mark deprecated variables with DNA_DEPRECATED, so they don't accidentally get used.
source/blender/physics/intern/implicit_blender.c
1616	Code style: comments start with capital letter and end with a dot.

This revision now requires changes to proceed.Aug 28 2018, 6:51 PM

Small update to fix issues raised by @Brecht Van Lommel (brecht). Thanks for the quick review!

Luca Rood (LucaRood) marked 2 inline comments as done.Aug 29 2018, 12:46 AM

Brecht Van Lommel (brecht) accepted this revision.Aug 30 2018, 1:31 PM

This revision is now accepted and ready to land.Aug 30 2018, 1:31 PM

Brecht Van Lommel (brecht) added a child revision: D3662: Cloth: angular bending springs.Aug 30 2018, 6:16 PM

Closed by commit rBe3d31b8dfbdc: Cloth: Componentize forces (authored by Luca Rood (LucaRood)). · Explain WhyAug 31 2018, 4:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

properties_physics_cloth.py

38 lines

source/

blender/

blenkernel/

8 lines

intern/

18 lines

particle_system.c

2 lines

blenloader/

intern/

versioning_280.c

24 lines

makesdna/

DNA_cloth_types.h

18 lines

makesrna/

intern/

179 lines

2 lines

physics/

intern/

BPH_mass_spring.cpp

38 lines

5 lines

implicit_blender.c

38 lines

Diff 11739

release/scripts/startup/bl_ui/properties_physics_cloth.py

Loading...

source/blender/blenkernel/BKE_cloth.h

Loading...

source/blender/blenkernel/intern/cloth.c

Loading...

source/blender/blenkernel/intern/particle_system.c

Loading...

source/blender/blenloader/intern/versioning_280.c

Loading...

source/blender/makesdna/DNA_cloth_types.h

Loading...

source/blender/makesrna/intern/rna_cloth.c

Loading...

source/blender/makesrna/intern/rna_particle.c

Loading...

source/blender/physics/intern/BPH_mass_spring.cpp

Loading...

source/blender/physics/intern/implicit.h

Loading...

source/blender/physics/intern/implicit_blender.c

Loading...