Page MenuHome
Differential D3656

Multi-Object-Mode: MESH_OT_blend_from_shape
ClosedPublic
Actions

Authored by Habib Gahbiche (zazizizou) on Aug 28 2018, 7:26 PM.

Details

Reviewers
Dalai Felinto (dfelinto)
Maniphest Tasks
T54643: Multi-Object-Mode: EditMesh Tools
Commits
rBS6ae09dfcad8b: Multi-Object-Mode: MESH_OT_blend_from_shape
rB6ae09dfcad8b: Multi-Object-Mode: MESH_OT_blend_from_shape
Summary

"Blend from Shape" lists keys from active object and applies to all selected objects that have keys with a matching name.

Also see discussion about operator's behaviour on blenderartists.org

Diff Detail

Repository
rB Blender
Branch
arcpatch-D3656 (branched from blender2.8)
Build Status
Buildable 1995
Build 1995: arc lint + arc unit

Event Timeline

Habib Gahbiche (zazizizou) created this revision.Aug 28 2018, 7:26 PM
Habib Gahbiche (zazizizou) added a task: T54643: Multi-Object-Mode: EditMesh Tools.
Habib Gahbiche (zazizizou) updated this revision to Diff 11738.Aug 31 2018, 4:36 PM

coding style: replaced spaces with tabs

Habib Gahbiche (zazizizou) edited the summary of this revision. (Show Details)Aug 31 2018, 7:43 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 31 2018, 8:24 PM
Closed by commit rB6ae09dfcad8b: Multi-Object-Mode: MESH_OT_blend_from_shape (authored by Habib Gahbiche (zazizizou), committed by Dalai Felinto (dfelinto)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Dalai Felinto (dfelinto) added a comment.Aug 31 2018, 8:26 PM

Thanks for the patch. Committed with the following changes;

  • Move Object **objects after sanity check to prevent leak when returning OPERATOR_CANCELLED.
  • Skip objects that have no selected vertex.
  • Code Style. (refer to your previous patches for more details, but more than tabs and spaces, in this case here you were inlining } else { which should break in two lines, and we add spaces after if and for (and after their ).
ezerai (ez) added a subscriber: ezerai (ez).Dec 23 2020, 8:58 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
mesh/
86 lines

Diff 11738

View Options

source/blender/editors/mesh/editmesh_tools.c

Loading...