Page MenuHome
Differential D3659

Multi-Object-Editing: MESH_OT_vertices_smooth_laplacian
ClosedPublic
Actions

Authored by Habib Gahbiche (zazizizou) on Aug 30 2018, 12:33 AM.

Details

Reviewers
Dalai Felinto (dfelinto)
Campbell Barton (campbellbarton)
Maniphest Tasks
T54643: Multi-Object-Mode: EditMesh Tools
Commits
rBS1f30232aa7d2: Multi-Object-Editing: MESH_OT_vertices_smooth_laplacian
rB1f30232aa7d2: Multi-Object-Editing: MESH_OT_vertices_smooth_laplacian
Summary

Since D3284 was inactive for a long time, I figured I could finish this.

This revision also gives warning when there are no selected faces or when selected faces are invalid.

Diff Detail

Repository
rB Blender
Branch
vertices_smooth_laplacian (branched from blender2.8)
Build Status
Buildable 1985
Build 1985: arc lint + arc unit

Event Timeline

Habib Gahbiche (zazizizou) created this revision.Aug 30 2018, 12:33 AM
Habib Gahbiche (zazizizou) added a task: T54643: Multi-Object-Mode: EditMesh Tools.
Habib Gahbiche (zazizizou) added a reviewer: Campbell Barton (campbellbarton).Aug 30 2018, 12:57 PM
Habib Gahbiche (zazizizou) updated this revision to Diff 11723.Aug 30 2018, 1:02 PM
Habib Gahbiche (zazizizou) edited the summary of this revision. (Show Details)
This revision was not accepted when it landed; it landed in state Needs Review.Aug 31 2018, 4:46 PM
Closed by commit rB1f30232aa7d2: Multi-Object-Editing: MESH_OT_vertices_smooth_laplacian (authored by Habib Gahbiche (zazizizou), committed by Dalai Felinto (dfelinto)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Dalai Felinto (dfelinto) added a comment.Aug 31 2018, 4:50 PM

Thanks for the patch, committed with sorted changes:

  • Code style (e.g., space after if, tabs as indentation instead of spaces).
  • Fix checking for ngons (BM_ITER_MESH is a for loop, you need to break from it before continuing the object iteration loop).

Remember to test next time ;) (ngons were producing a crash), and please visit:

source/blender/editors/mesh/editmesh_tools.c
2324

In your original patch you were using continue here. However the BM_ITER_MESH is a for loop, so you were not breaking away from here. Fixed in the committed code.

Campbell Barton (campbellbarton) mentioned this in D3362: Edit Mesh: multi-object smooth laplacian vertex support.Apr 5 2022, 7:08 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
mesh/
90 lines

Diff 11723

View Options

source/blender/editors/mesh/editmesh_tools.c

Loading...