Paths

Table of Contentst

Differential D3744

Misc. typo fixes pt5
ClosedPublic
Actions

Authored by luzpaz (luzpaz) on Sep 28 2018, 5:14 AM.

Tags

None

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rB604fdb6e859d: Spelling fixes in comments and descriptions, patch by luzpaz

Summary

Found via codespell -q 3 -I ../blender-word-whitelist.txt --skip="./extern,./intern,./doc/license,./tests/gtests,*.diff"
Followup to D3732

Diff Detail

Repository: rB Blender

Event Timeline

@Brecht Van Lommel (brecht) is there any issue with fixing typos for ./release/scripts/addons ?

Fixes for addons are fine.

How many of these are you planning to submit still? It would be easier for me if it was just one big patch. For some patches splitting it up into smaller parts helps, for spelling fixes that's not really the case though.

In D3744#85570, @Brecht Van Lommel (brecht) wrote:

How many of these are you planning to submit still? It would be easier for me if it was just one big patch. For some patches splitting it up into smaller parts helps, for spelling fixes that's not really the case though.

I see. I can add the rest of the changes to this commit or just submit the last patch after this one? how do you prefer ?

Also please respond to https://developer.blender.org/D3744?large=true#inline-33463

source/blender/blenlib/intern/path_util.c
1528 ↗	(On Diff #11987)	it is assumed `void` or `valid` ?

You can add the rest of the changes to this commit.

source/blender/blenlib/intern/path_util.c
1528 ↗	(On Diff #11987)	`valid`.

I'm still not used to using phabricator, so I apologize. So a couple if issues:

I rebased the diff over blender2.8 branch again
I added some leftover commits (unfortnately none of them were from the addons because...
my git client is a GUI and there is a bug that wasn't showing me the commits I made in the addons because it was in a submodule. So I'm going to make a patch from within the submodules for the next commit.

Sorry for the confusion

@Brecht Van Lommel (brecht) hi, just checking on this. Anything you need me to do before it gets committed ?

Should I rebase ?

@Brecht Van Lommel (brecht) i rebased the patch locally. I can break it up in to 2 smaller patches, if you want.

I can look at this a bit after the 2.80 release.

The current patch seems to include whitespace changes in intern/elbeem.

All whitespaces removed.

Brecht Van Lommel (brecht) accepted this revision.Jul 31 2019, 2:28 PM

This revision is now accepted and ready to land.Jul 31 2019, 2:28 PM

Closed by commit rB604fdb6e859d: Spelling fixes in comments and descriptions, patch by luzpaz (authored by Brecht Van Lommel (brecht)). · Explain WhyJul 31 2019, 2:29 PM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB604fdb6e859d: Spelling fixes in comments and descriptions, patch by luzpaz.

Revision Contents
Changeset List

Path

Size

build_files/

cmake/

clang_array_check.py

2 lines

cmake_netbeans_project.py

2 lines

package_spec/

build_debian.sh

2 lines

doc/

guides/

interface_API.txt

2 lines

python_api/

rst/

info_gotcha.rst

4 lines

info_tips_and_tricks.rst

2 lines

intern/

elbeem/

intern/

4 lines

ntl_vector3dim.h

4 lines

solver_init.cpp

2 lines

libmv/

intern/

track_region.cc

2 lines

release/

scripts/

modules/

bl_i18n_utils/

2 lines

bl_keymap_utils/

2 lines

bpy_extras/

object_utils.py

2 lines

rna_keymap_ui.py

2 lines

startup/

bl_ui/

properties_physics_common.py

4 lines

2 lines

space_toolsystem_common.py

4 lines

space_view3d_toolbar.py

4 lines

source/

blender/

blenkernel/

intern/

2 lines

2 lines

library_query.c

2 lines

2 lines

2 lines

tracking_auto.c

2 lines

blenlib/

intern/

4 lines

4 lines

2 lines

2 lines

8 lines

bmesh/

intern/

bmesh_construct.c

8 lines

2 lines

bmesh_marking.c

4 lines

2 lines

bmesh_opdefines.c

2 lines

bmesh_operator_api.h

2 lines

bmesh_polygon_edgenet.c

4 lines

bmesh_structure.h

4 lines

bmesh_walkers_impl.c

2 lines

operators/

2 lines

2 lines

2 lines

2 lines

bmo_subdivide.c

2 lines

tools/

bmesh_decimate_collapse.c

4 lines

bmesh_path_region.c

4 lines

bmesh_region_match.c

6 lines

collada/

AnimationImporter.cpp

2 lines

DocumentImporter.cpp

2 lines

datatoc/

datatoc_icon_split.py

2 lines

draw/

engines/

eevee/

shaders/

effect_dof_frag.glsl

4 lines

raytrace_lib.glsl

2 lines

modes/

edit_curve_mode.c

2 lines

shaders/

common_hair_lib.glsl

4 lines

editors/

mesh/

2 lines

physics/

particle_edit.c

2 lines

sculpt_paint/

paint_image_proj.c

10 lines

space_graph/

2 lines

space_sequencer/

sequencer_edit.c

2 lines

space_view3d/

2 lines

transform/

2 lines

freestyle/

intern/

geometry/

2 lines

2 lines

2 lines

2 lines

2 lines

image/

GaussianFilter.h

2 lines

python/

BPy_Iterator.cpp

4 lines

Iterator/

BPy_Interface0DIterator.cpp

2 lines

BPy_StrokeVertexIterator.cpp

2 lines

scene_graph/

IndexedFaceSet.h

6 lines

2 lines

stroke/

BasicStrokeShaders.cpp

8 lines

2 lines

2 lines

CurveAdvancedIterators.h

4 lines

CurveIterators.h

2 lines

2 lines

system/

2 lines

view_map/

CulledOccluderSource.cpp

4 lines

FEdgeXDetector.cpp

4 lines

4 lines

ViewEdgeXBuilder.h

6 lines

ViewEdgeXBuilder.cpp

6 lines

8 lines

ViewMapBuilder.cpp

2 lines

winged_edge/

2 lines

ikplugin/

intern/

itasc_plugin.cpp

2 lines

imbuf/

2 lines

nodes/

composite/

nodes/

node_composite_cryptomatte.c

4 lines

node_composite_vecBlur.c

2 lines

render/

intern/

source/

6 lines

creator/

creator_signals.c

2 lines

Diff 16718

build_files/cmake/clang_array_check.py

Loading...

build_files/cmake/cmake_netbeans_project.py

Loading...

build_files/package_spec/build_debian.sh

Loading...

doc/guides/interface_API.txt

Loading...

doc/python_api/rst/info_gotcha.rst

Loading...

doc/python_api/rst/info_tips_and_tricks.rst

Loading...

intern/elbeem/intern/isosurface.h

Loading...

intern/elbeem/intern/ntl_vector3dim.h

Loading...

intern/elbeem/intern/solver_init.cpp

Loading...

intern/libmv/intern/track_region.cc

Loading...

release/scripts/modules/bl_i18n_utils/utils.py

Loading...

release/scripts/modules/bl_keymap_utils/io.py

Loading...

release/scripts/modules/bpy_extras/object_utils.py

Loading...

release/scripts/modules/rna_keymap_ui.py

Loading...

release/scripts/startup/bl_ui/properties_physics_common.py

Loading...

release/scripts/startup/bl_ui/space_clip.py

Loading...

release/scripts/startup/bl_ui/space_toolsystem_common.py

Loading...

release/scripts/startup/bl_ui/space_view3d_toolbar.py

Loading...

source/blender/blenkernel/intern/constraint.c

Loading...

source/blender/blenkernel/intern/fcurve.c

Loading...

source/blender/blenkernel/intern/library_query.c

Loading...

source/blender/blenkernel/intern/pointcache.c

Loading...

source/blender/blenkernel/intern/sequencer.c

Loading...

source/blender/blenkernel/intern/tracking_auto.c

Loading...

source/blender/blenlib/intern/BLI_kdopbvh.c

Loading...

source/blender/blenlib/intern/array_store.c

Loading...

source/blender/blenlib/intern/fileops.c

Loading...

source/blender/blenlib/intern/polyfill_2d.c

Loading...

source/blender/blenlib/intern/rct.c

Loading...

source/blender/bmesh/intern/bmesh_construct.c

Loading...

source/blender/bmesh/intern/bmesh_core.c

Loading...

source/blender/bmesh/intern/bmesh_marking.c

Loading...

source/blender/bmesh/intern/bmesh_mesh.c

Loading...

source/blender/bmesh/intern/bmesh_opdefines.c

Loading...

source/blender/bmesh/intern/bmesh_operator_api.h

Loading...

source/blender/bmesh/intern/bmesh_polygon_edgenet.c

Loading...

source/blender/bmesh/intern/bmesh_structure.h

Loading...

source/blender/bmesh/intern/bmesh_walkers_impl.c

Loading...

source/blender/bmesh/operators/bmo_bridge.c

Loading...

source/blender/bmesh/operators/bmo_dupe.c

Loading...

source/blender/bmesh/operators/bmo_edgenet.c

Loading...

source/blender/bmesh/operators/bmo_inset.c

Loading...

source/blender/bmesh/operators/bmo_subdivide.c

Loading...

source/blender/bmesh/tools/bmesh_decimate_collapse.c

Loading...

source/blender/bmesh/tools/bmesh_path_region.c

Loading...

source/blender/bmesh/tools/bmesh_region_match.c

Loading...

source/blender/collada/AnimationImporter.cpp

Loading...

source/blender/collada/DocumentImporter.cpp

Loading...

source/blender/datatoc/datatoc_icon_split.py

Loading...

source/blender/draw/engines/eevee/shaders/effect_dof_frag.glsl

Loading...

source/blender/draw/engines/eevee/shaders/raytrace_lib.glsl

Loading...

source/blender/draw/modes/edit_curve_mode.c

Loading...

source/blender/draw/modes/shaders/common_hair_lib.glsl

Loading...

source/blender/editors/mesh/mesh_mirror.c

Loading...

source/blender/editors/physics/particle_edit.c

Loading...

source/blender/editors/sculpt_paint/paint_image_proj.c

Loading...

source/blender/editors/space_graph/graph_draw.c

Loading...

source/blender/editors/space_sequencer/sequencer_edit.c

Loading...

source/blender/editors/space_view3d/view3d_edit.c

Loading...

source/blender/editors/transform/transform.h

Loading...

source/blender/freestyle/intern/geometry/FastGrid.h

Loading...

source/blender/freestyle/intern/geometry/GeomUtils.cpp

Loading...

source/blender/freestyle/intern/geometry/Grid.h

Loading...

source/blender/freestyle/intern/geometry/HashGrid.h

Loading...

source/blender/freestyle/intern/geometry/VecMat.h

Loading...

source/blender/freestyle/intern/image/GaussianFilter.h

Loading...

source/blender/freestyle/intern/python/BPy_Iterator.cpp

Loading...

source/blender/freestyle/intern/python/Iterator/BPy_Interface0DIterator.cpp

Loading...

source/blender/freestyle/intern/python/Iterator/BPy_StrokeVertexIterator.cpp

Loading...

source/blender/freestyle/intern/scene_graph/IndexedFaceSet.h

Loading...

source/blender/freestyle/intern/scene_graph/NodeGroup.h

Loading...

source/blender/freestyle/intern/stroke/BasicStrokeShaders.cpp

Loading...

source/blender/freestyle/intern/stroke/Chain.h

Loading...

source/blender/freestyle/intern/stroke/Curve.h

Loading...

source/blender/freestyle/intern/stroke/CurveAdvancedIterators.h

Loading...

source/blender/freestyle/intern/stroke/CurveIterators.h

Loading...

source/blender/freestyle/intern/stroke/Stroke.h

Loading...

source/blender/freestyle/intern/system/BaseIterator.h

Loading...

source/blender/freestyle/intern/view_map/CulledOccluderSource.cpp

Loading...

source/blender/freestyle/intern/view_map/FEdgeXDetector.cpp

Loading...

source/blender/freestyle/intern/view_map/Silhouette.h

Loading...

source/blender/freestyle/intern/view_map/ViewEdgeXBuilder.h

Loading...

source/blender/freestyle/intern/view_map/ViewEdgeXBuilder.cpp

Loading...

source/blender/freestyle/intern/view_map/ViewMap.h

Loading...

source/blender/freestyle/intern/view_map/ViewMapBuilder.cpp

Loading...

source/blender/freestyle/intern/winged_edge/Curvature.cpp

Loading...

source/blender/ikplugin/intern/itasc_plugin.cpp

Loading...

source/blender/imbuf/readme.txt

Loading...

source/blender/nodes/composite/nodes/node_composite_cryptomatte.c

Loading...

source/blender/nodes/composite/nodes/node_composite_vecBlur.c

Loading...

source/blender/render/intern/source/pipeline.c

Loading...

source/creator/creator_signals.c

Loading...