Page MenuHome
Differential D37

T37438 'Redo' panel shows useless internal data
ClosedPublic
Actions

Authored by Emanuel Claesson (EClaesson) on Nov 24 2013, 12:56 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Thomas Dinges (dingto)
Group Reviewers
User Interface
Maniphest Tasks
T37438: Tool settings panel shows useless internal data
Commits
rBS24990ff0bf2e: UI: hide internal properties of radial control operator from user.
rB24990ff0bf2e: UI: hide internal properties of radial control operator from user.
Summary

Ref T37438

This hides the properties for radial control.
Should it be done any other way?

Diff Detail

Event Timeline

Brecht Van Lommel (brecht) added a comment.Nov 24 2013, 1:03 AM

The implementation is correct, but I prefer to have the property assigned to a PropertyRNA *prop variable and to do RNA_def_property_flag(prop, PROP_HIDDEN) on a separate line.

Emanuel Claesson (EClaesson) updated this revision to Unknown Object (????).Nov 24 2013, 1:27 AM

RNA_def_property_flag calls are now on separate lines from their RNA_defs.

Thomas Dinges (dingto) accepted this revision.Nov 24 2013, 10:43 PM

Looks good to me.

Brecht Van Lommel (brecht) accepted this revision.Nov 25 2013, 5:14 AM

Thanks, looks good, will commit tomorrow.

Brecht Van Lommel (brecht) closed this revision.Nov 25 2013, 12:49 PM

Closed by commit rB24990ff0bf2e (authored by @Emanuel Claesson (EClaesson), committed by @Brecht Van Lommel (brecht)).

Revision Contents
Changeset List

PathSize
source/
blender/
windowmanager/
intern/
37 lines

Diff 90

View Options

source/blender/windowmanager/intern/wm_operators.c

Loading...