Ubuntu 18.04 System Bookmarks filter out SNAPS
ClosedPublic
Actions

Authored by Roel Koster (kostex) on Oct 27 2018, 11:48 PM.

Details

Reviewers

Commits

rBSe3d2df038001: Fix snaps appearing in system bookmarks on Linux.
rBe3d2df038001: Fix snaps appearing in system bookmarks on Linux.

Summary

Brecht,
in 2009 you've stated in the code (fsmenu.c) that filtering system bookmarks on /dev should get you all the relevant ones..
I've recently installed Ubuntu 18.04 and it makes use of SNAPS which are entered in the mountlist as
/dev/loopxxx

These should not show up in the system bookmarks when opening/saving in Ubuntu
I've made a small patch to filter them out.
Adjust at will ;-)

Thanks
Roel

Diff Detail

Repository: rB Blender

Event Timeline

Roel Koster (kostex) created this revision.Oct 27 2018, 11:48 PM

BTW.. I don't know if this qualifies as feature request, but when starting out with Linux years ago, I always found it difficult to find shares made by Nautilus/Files (UI) in Ubuntu and other distro's. A new user will have that same "where are they in Blender" question.
Maybe have them available too? The /run/user/<username>/gvfs folder I mean.

Thanks,
Roel

If you want to contribute another patch to list shares from Gnome or other desktops, we would be happy to have it. It would be good to check if there is a freedesktop standard for this kind of thing, or some other convention that is used by other software, before guessing the appropriate directories.

This revision is now accepted and ready to land.Oct 28 2018, 3:14 PM

Closed by commit rBe3d2df038001: Fix snaps appearing in system bookmarks on Linux. (authored by Roel Koster (kostex), committed by Brecht Van Lommel (brecht)). · Explain WhyOct 28 2018, 3:14 PM

This revision was automatically updated to reflect the committed changes.

Hi Brecht,

I've noticed another snap related folder shows up in the filesystems list which doesn't belong in the Volumes list.
On my Ubuntu 18.04 LTS system a file system entry shows up in Blenders' File Manager:
/dev/nvme0n1p2 : /tmp/snap.rootfs_MpPbk3
I don't quite know why this appears now.. never seen it before.

To filter it out something like this could be added:

else if (STRPREFIX(mnt->mnt_dir, "/tmp")) {
  continue;
}

I wasn't quite sure how to submit this little patch so forgive me for pasting it here in this message.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_file/

fsmenu.c

2 lines

Diff 12259

View Options

source/blender/editors/space_file/fsmenu.c

Ubuntu 18.04 System Bookmarks filter out SNAPSClosedPublicActions