Page MenuHome
Differential D3847

Fix crash importing alembic with mcol indices out of bounds
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Oct 29 2018, 1:38 PM.

Details

Reviewers
Sybren A. Stüvel (sybren)
Maniphest Tasks
T57377: Alembic animated content import
Commits
rBS436f1a2afad3: Alembic import: Fix crash with mcol indices out of bounds
rB436f1a2afad3: Alembic import: Fix crash with mcol indices out of bounds
Summary

part of T57377

Diff Detail

Repository
rB Blender
Branch
T57377 (branched from blender2.8)
Build Status
Buildable 2318
Build 2318: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Oct 29 2018, 1:38 PM
Harbormaster completed remote builds in B2318: Diff 12279.Oct 29 2018, 1:38 PM
Philipp Oeser (lichtwerk) added a reviewer: Sybren A. Stüvel (sybren).Oct 29 2018, 1:39 PM
Philipp Oeser (lichtwerk) mentioned this in T57377: Alembic animated content import.
Sybren A. Stüvel (sybren) added a comment.Dec 28 2018, 4:11 PM

LGTM; I think it's a good idea to not use data when we detect an out-of-bounds error.

source/blender/alembic/intern/abc_customdata.cc
398

I think that if (is_mcols_out_of_bounds) { continue; } would be more elegant here.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 28 2018, 4:53 PM
Closed by commit rB436f1a2afad3: Alembic import: Fix crash with mcol indices out of bounds (authored by Philipp Oeser (lichtwerk), committed by Sybren A. Stüvel (sybren)). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
alembic/
intern/
35 lines

Diff 12279

View Options

source/blender/alembic/intern/abc_customdata.cc

Loading...