Not much to say here, besides that we try to get rid of OMP in Blender code, so might be better to default to tbb, unless there is a good reason not to do so?

Also more a topic for @Sergey Sharybin (sergey), but iirc with tbb we should be able to integrate it to our threading management system at some point (to avoid having too much running threads, which is very inefficient), while that would not be possible with OMP?

Okay, it's actually very good that we talk about OpenMP & TBB. I made some tests and it appears that TBB generally performs much, much better (e.g. smoke scenes 50% faster with TBB, @Juan Gea (juang3d) had similar results).

I would also say the default should be TBB. In the future we might remove OpenMP altogether. @Nils Thuerey (n_t) or would you say that some development will only take place in OpenMP, i.e. any drawbacks using just TBB?

@Sebastián Barschkis (sebbas) yes, good idea - we're using TBB with mantaflow for a long time now, and it works very nicely. We also saw performance gains in the past, less than 50%, but gains nonetheless. So I don't see a reason not to focus on TBB. That way we could also get rid of the somewhat redundant code for OpenMP.

Yes, the 2 files with main() are not needed and can be removed. Same is true for all the *.reg files.

The manta update script (extern/mantaflow/UPDATE.sh) now also makes a call to dos2unix before copying over the source files. So they'll always be formatted correctly after updating them.

I'll first commit everyting into fluid-mantaflow and then update the patches.

fc557cdd138c has the updates for this diff.