Smaller changes in the build files to reflect the new Mantaflow macro.
Details
Details
- Reviewers
Brecht Van Lommel (brecht) Sergey Sharybin (sergey) Nils Thuerey (n_t) Georg Kohl (GeorgKohl) - Maniphest Tasks
- T59995: Mantaflow Review
- Commits
- rB41fd60db16fc: Mantaflow [Part 4]: Adapted build config
rB9159d9bebcf1: Merge branch 'pythonScripts' into buildConfig
rBe9ee13d4d690: Merge branch 'pythonScripts' into buildConfig
rB3e11933329ce: Mantaflow: Adapted build config
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- buildConfig (branched from master)
- Build Status
Buildable 6019 Build 6019: arc lint + arc unit
Event Timeline
| CMakeLists.txt | ||
|---|---|---|
| 244–245 | I guess that one should be removed? | |
| 1693–1694 | Same, to be removed? | |
| build_files/cmake/config/blender_lite.cmake | ||
| 39–40 | And to be removed too. | |
| build_files/cmake/config/blender_release.cmake | ||
| 33–34 | And again ;) | |
| build_files/cmake/macros.cmake | ||
| 451–453 ↗ | (On Diff #14645) | I thought tbb was only enabled if(NOT WITH_OPENMP)? Or is MantaFlow always using tbb, even when OMP is enabled? |
| CMakeLists.txt | ||
|---|---|---|
| 1207–1209 | Is it really required to be global? | |
| CMakeLists.txt | ||
|---|---|---|
| 1207–1209 | 82d75a46ce37 fixes this issue as well. | |
Comment Actions
A bit confusing since the fix is commitetd to Git and not reflected here. But doing such kind of update takes a lot of effort with arc apparently :/
So this + the fix you've mentioned is fine.
Would be nice if things are committed to master somewhat separate still (not just merge-everything-from-the-branch), but that's separate story.