Mantaflow [Part 5]: Update other /intern packages
ClosedPublic
Actions

Authored by Sebastián Barschkis (sebbas) on Oct 29 2018, 5:20 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)
Nils Thuerey (n_t)
Georg Kohl (GeorgKohl)
Bastien Montagne (mont29)

Maniphest Tasks

T59995: Mantaflow Review

Commits

rB7bd3d2be0807: Mantaflow [Part 5]: Update other /intern packages
rBf9a7a90557e8: Merge branch 'buildConfig' into internUpdate
rBa8a9f6aae1d0: Merge branch 'buildConfig' into internUpdate
rBed417d796be1: Mantaflow: Update other /intern packages

Summary

Cycles needs some smaller updates so that the up-res smoke wavelet noise and the liquid mesh speed vector export work correctly.

Diff Detail

Repository: rB Blender

Event Timeline

Sebastián Barschkis (sebbas) created this revision.Oct 29 2018, 5:20 PM

Martin Felke (scorpion81) added a subscriber: Martin Felke (scorpion81).Nov 25 2018, 5:34 PM

Jérôme Matthey (JeromeM) added a subscriber: Jérôme Matthey (JeromeM).Dec 28 2018, 11:29 PM

Bastien Montagne (mont29) added a task: T59995: Mantaflow Review.Dec 30 2018, 10:07 PM

Update manta files after merge with master.

Harbormaster completed remote builds in B3295: Diff 14646.Apr 6 2019, 2:19 PM

Harbormaster completed remote builds in B3295: Diff 14646.

Bastien Montagne (mont29) added a subscriber: Bastien Montagne (mont29).May 4 2019, 11:12 AM

Bastien Montagne (mont29) added inline comments.

intern/CMakeLists.txt
43–45 ↗	(On Diff #14646)	Again, to be removed?
intern/smoke/CMakeLists.txt
96–97	Just remove this then. :)

not much to say here, looks good but think at least @Brecht Van Lommel (brecht) will want to check on that one too.

The code logic seems fine since it's just a copy of the fluid stuff. The naming is weird in that it refers to smoke while we are dealing with mesh surfaces, but I guess that has already been brought up in the other code reviews.

Mantaflow [Part 5]: Update other /intern packagesClosedPublicActions

Details

Diff Detail

Event Timeline

Large Diff

Revision ContentsChangeset List

Diff 20322

intern/elbeem/CMakeLists.txt

intern/elbeem/COPYING

intern/elbeem/COPYING_trimesh2

intern/elbeem/extern/LBM_fluidsim.h

intern/elbeem/extern/elbeem.h

intern/elbeem/intern/attributes.h

intern/elbeem/intern/attributes.cpp

intern/elbeem/intern/controlparticles.h

intern/elbeem/intern/controlparticles.cpp

intern/elbeem/intern/elbeem.cpp

intern/elbeem/intern/elbeem_control.h

intern/elbeem/intern/elbeem_control.cpp

intern/elbeem/intern/globals.h

intern/elbeem/intern/isosurface.h

intern/elbeem/intern/isosurface.cpp

intern/elbeem/intern/loop_tools.h

intern/elbeem/intern/mcubes_tables.h

intern/elbeem/intern/mvmcoords.h

intern/elbeem/intern/mvmcoords.cpp

intern/elbeem/intern/ntl_blenderdumper.h

intern/elbeem/intern/ntl_blenderdumper.cpp

intern/elbeem/intern/ntl_bsptree.h

intern/elbeem/intern/ntl_bsptree.cpp

intern/elbeem/intern/ntl_geometryclass.h

intern/elbeem/intern/ntl_geometrymodel.h

intern/elbeem/intern/ntl_geometrymodel.cpp

intern/elbeem/intern/ntl_geometryobject.h

intern/elbeem/intern/ntl_geometryobject.cpp

intern/elbeem/intern/ntl_geometryshader.h

intern/elbeem/intern/ntl_lighting.h

intern/elbeem/intern/ntl_lighting.cpp

intern/elbeem/intern/ntl_matrices.h

intern/elbeem/intern/ntl_ray.h

intern/elbeem/intern/ntl_ray.cpp

intern/elbeem/intern/ntl_vector3dim.h

intern/elbeem/intern/ntl_world.h

intern/elbeem/intern/ntl_world.cpp

intern/elbeem/intern/paraloopend.h

intern/elbeem/intern/parametrizer.h

intern/elbeem/intern/parametrizer.cpp

intern/elbeem/intern/particletracer.h

intern/elbeem/intern/particletracer.cpp

intern/elbeem/intern/simulation_object.h

intern/elbeem/intern/simulation_object.cpp

intern/elbeem/intern/solver_adap.cpp

intern/elbeem/intern/solver_class.h

intern/elbeem/intern/solver_control.h

intern/elbeem/intern/solver_control.cpp

intern/elbeem/intern/solver_init.cpp

intern/elbeem/intern/solver_interface.h

intern/elbeem/intern/solver_interface.cpp

intern/elbeem/intern/solver_main.cpp

intern/elbeem/intern/solver_relax.h

intern/elbeem/intern/solver_util.cpp

intern/elbeem/intern/utilities.h

intern/elbeem/intern/utilities.cpp

intern/smoke/CMakeLists.txt

intern/smoke/extern/smoke_API.h

intern/smoke/intern/EIGENVALUE_HELPER.h

intern/smoke/intern/EIGENVALUE_HELPER.cpp

intern/smoke/intern/FFT_NOISE.h

intern/smoke/intern/FLUID_3D.h

intern/smoke/intern/FLUID_3D.cpp

intern/smoke/intern/FLUID_3D_SOLVERS.cpp

intern/smoke/intern/FLUID_3D_STATIC.cpp

intern/smoke/intern/IMAGE.h

intern/smoke/intern/INTERPOLATE.h

intern/smoke/intern/LICENSE.txt

intern/smoke/intern/LU_HELPER.h

intern/smoke/intern/LU_HELPER.cpp

intern/smoke/intern/MERSENNETWISTER.h

intern/smoke/intern/Makefile.FFT

intern/smoke/intern/Makefile.cygwin

Mantaflow [Part 5]: Update other /intern packages
ClosedPublic
Actions

Revision Contents
Changeset List