Details

Reviewers

Sergey Sharybin (sergey)
Nils Thuerey (n_t)
Georg Kohl (GeorgKohl)
Bastien Montagne (mont29)

Maniphest Tasks

T59995: Mantaflow Review

Commits

rB829a83262f8f: Mantaflow [Part 7]: Added bake configuration
rBa71f1dec8f91: Mantaflow: Updated manta bake job setup
rB319ce72c3a4a: Merge branch 'sourceUpdate' into bakeConfig
rB287b26f910a3: Merge branch 'sourceUpdate' into bakeConfig
rB4ddf0b68129f: Mantaflow: Added bake configuration

Summary

Similarly to physics_fluid.c (in same directory) which handled the baking process for Elbeem, there is now physics_manta.c which handles it for Mantaflow.

There are two types of jobs: one for baking and another for freeing. The generic jobs will be used to bake / free specific parts of the simulation (e.g. bake mesh, free particles, etc.).

The jobs are only being used in the "modular" cache mode where the simulation has to be baked in parts.

Diff Detail

Repository: rB Blender

Event Timeline

Sebastián Barschkis (sebbas) created this revision.Oct 29 2018, 5:37 PM

Martin Felke (scorpion81) added a subscriber: Martin Felke (scorpion81).Nov 25 2018, 5:34 PM

Jérôme Matthey (JeromeM) added a subscriber: Jérôme Matthey (JeromeM).Dec 28 2018, 11:30 PM

Bastien Montagne (mont29) added a task: T59995: Mantaflow Review.Dec 30 2018, 10:07 PM

Update manta files after merge with master.

Harbormaster completed remote builds in B3297: Diff 14648.Apr 6 2019, 2:23 PM

Harbormaster completed remote builds in B3297: Diff 14648.

Very quick review, would need a slightly deeper pass on that one but from first sight nothing wrong here.

source/blender/editors/physics/physics_manta.c
76 ↗	(On Diff #14648)	Naming again, would rather see `Manta` first in names (also for the functions below).

Updated diff with latest changes from fluid-mantaflow branch

Harbormaster completed remote builds in B4645: Diff 17624.Aug 28 2019, 8:27 PM

Updated diff with latest changes from fluid-mantaflow branch

Harbormaster completed remote builds in B5832: Diff 19936.Nov 28 2019, 6:20 PM

Sebastián Barschkis (sebbas) edited the summary of this revision. (Show Details)Dec 5 2019, 5:46 PM

Sebastián Barschkis (sebbas) edited reviewers, added: Bastien Montagne (mont29); removed: Brecht Van Lommel (brecht).

Sergey Sharybin (sergey) requested changes to this revision.Dec 10 2019, 3:07 PM

Sergey Sharybin (sergey) added inline comments.

source/blender/editors/physics/physics_manta.c
255 ↗	(On Diff #19936)	Pretty much sure there is more reliably way that doing string comparison with an operator name.
296 ↗	(On Diff #19936)	No need to calculate length of string to see if it's empty. Additionally, error might be nullptr. `if (mds->error != NULL && mds->error[0] != '\0')`.

This revision now requires changes to proceed.Dec 10 2019, 3:07 PM

See 2fcf705a17dd for changes.

source/blender/editors/physics/physics_manta.c
255 ↗	(On Diff #19936)	I agree, not very nice. I cleaned it up a bit so that strings and `STREQ()` only show up once. But since `wmOperatorType->idname` is a `char *` I don't know how we could identify a job. `wmOperatorType->idname` is also supposed to be a "Unique identifier".

There is still room for improvement, but those could happen as a regular development. At least now refactor wouldn't miss anything important.

source/blender/editors/physics/physics_manta.c
255 ↗	(On Diff #19936)	`wmOperatorType->idname` is also supposed to be a "Unique identifier". Sure, but it was very simple to miss identifier in a string after refactor. With a `define` (after your update) it's no longer the case. Guess in an ideal word we would store a bake type in `MantaJob`. Not sure the boiler plate will keep this good feeling on a good level though.