All new simulation parameters need to be registered in the RNA. Especially for liquids a lot of new ones need to be added.
Details
Details
- Reviewers
Brecht Van Lommel (brecht) Sergey Sharybin (sergey) Nils Thuerey (n_t) Georg Kohl (GeorgKohl) - Maniphest Tasks
- T59995: Mantaflow Review
- Commits
- rBdb8726dfd53f: Mantaflow [Part 9]: Updated rna smoke code
rBa261b850f142: Mantaflow: Minor update in smoke rna
rBa2abfcbfc1e7: Merge branch 'particleSystem' into rnaSmoke
rBa38c14aecb8c: Merge branch 'particleSystem' into rnaSmoke
rB1c6da92b1a5e: Mantaflow: Updated rna smoke code
Diff Detail
Diff Detail
- Repository
- rB Blender
Event Timeline
Comment Actions
@Sergey Sharybin (sergey) Smoke and liquid RNA now live in the same file - this manta RNA.
So mostly boilerplate RNA stuff going on here that picks up the changes from the Manta structs in D3860.
Comment Actions
Keep in mind comment from @Brecht Van Lommel (brecht) and me in D3855 about not really exposing "manta" to user interface.
| source/blender/makesrna/intern/rna_manta.c | ||
|---|---|---|
| 122–139 ↗ | (On Diff #19939) | Such code usually belongs to BKE. |
| 148–160 ↗ | (On Diff #19939) | Same as above. |
| 397–401 ↗ | (On Diff #19939) | Should it be something more like "delete all but?". Or "delete all" and then create? |
Comment Actions
See 5d009982b151 for changes.
| source/blender/makesrna/intern/rna_manta.c | ||
|---|---|---|
| 397–401 ↗ | (On Diff #19939) | Mmh, it's not a "delete all", more like a "delete all that have a type we want to create now". I think by & checking the types in the delete new function BKE_manta_delete_particle_system() it should work. I.e. there are now fewer deletion calls. |
This comment was removed by Juan Gea (juang3d).
Comment Actions
Ok, something what could be controversial.
Function names are to be changed to rna_def_fluid_FOO, rna_Fluid_FOO and so on. But i'd rather see project in a master and have such rename happen soon after that than to delay project, shift bcon2 and things like that.
That is my optinion on this anyway.