Multi-Object EditMode: MBALL_OT_select_similar
ClosedPublic
Actions

Authored by Habib Gahbiche (zazizizou) on Nov 4 2018, 8:18 PM.

Details

Reviewers

Dalai Felinto (dfelinto)
Campbell Barton (campbellbarton)

Maniphest Tasks

T54649: Multi-Object-Mode: Edit MetaBall Tools

Commits

rBS5f8d3694958a: Multi-Objects: MBALL_OT_select_similar
rB5f8d3694958a: Multi-Objects: MBALL_OT_select_similar

Summary

Note: The block marked as TEMPORARY needs to be deleted if D3845 is accepted.

Compared to previous implementation, the following has been changed:

Threshold: is now an absolute value. This allows a comparison with e.g. radii that are much larger than selected radius. This is also consistent with CURVE_OT_select_similar
Radius in world space is the average of the radius scaled in x, y and z directions
Since MetaBalls are symmetrical, rotation is only considered from 0 to π/2. So for example rotations of 90° and -90° are considered equal. This is also consistent with the way CURVE_OT_select_similar works.

Diff Detail

Repository

rB Blender

Branch

MBALL_OT_select_similar (branched from blender2.8)

Build Status

Buildable 2394
Build 2394: arc lint + arc unit

Event Timeline

Habib Gahbiche (zazizizou) created this revision.Nov 4 2018, 8:18 PM

Habib Gahbiche (zazizizou) added reviewers: Dalai Felinto (dfelinto), Campbell Barton (campbellbarton).

Habib Gahbiche (zazizizou) added a task: T54649: Multi-Object-Mode: Edit MetaBall Tools.

Please, please test your patches thoroughly ;) This doesn't update the metaballs drawing unless you manually force viewport to update. I'm fixing this and the changed issue and committing.

source/blender/editors/metaball/mball_edit.c
307	changed should be initialized to false.
443	This should be outside the switch {}. the way it is it never runs.

This revision now requires changes to proceed.Nov 7 2018, 3:11 AM

This revision was not accepted when it landed; it landed in state Needs Revision.Nov 7 2018, 3:16 AM

Closed by commit rB5f8d3694958a: Multi-Objects: MBALL_OT_select_similar (authored by Habib Gahbiche (zazizizou), committed by Dalai Felinto (dfelinto)). · Explain Why

This revision was automatically updated to reflect the committed changes.

In D3895#88664, @Dalai Felinto (dfelinto) wrote:

Please, please test your patches thoroughly ;) This doesn't update the metaballs drawing unless you manually force viewport to update.

I honestly thought the update issue was not related to this operator because metaballs were being partially updated. I promise I'll be more careful with testing though. Thanks a lot for the feedback!