Page MenuHome
Differential D3896

Multi-Object-Mode: SIMFACE_AREA
ClosedPublic
Actions

Authored by Habib Gahbiche (zazizizou) on Nov 5 2018, 12:51 AM.

Details

Reviewers
Dalai Felinto (dfelinto)
Maniphest Tasks
T56948: Multi-Object-Mode: Operators that need refactor on their logic
Summary

Compute face area in world space.

Limits:

  • Threshold is used for comparison. This comes with the inherent limits of comparing floating points.

Diff Detail

Repository
rB Blender
Branch
MESH_OT_select_similar_AREA (branched from blender2.8)
Build Status
Buildable 2406
Build 2406: arc lint + arc unit

Event Timeline

Habib Gahbiche (zazizizou) created this revision.Nov 5 2018, 12:51 AM
Habib Gahbiche (zazizizou) added a task: T56948: Multi-Object-Mode: Operators that need refactor on their logic.Nov 5 2018, 1:10 AM
Habib Gahbiche (zazizizou) updated this revision to Diff 12402.Nov 6 2018, 1:34 AM
Habib Gahbiche (zazizizou) edited the summary of this revision. (Show Details)
Habib Gahbiche (zazizizou) edited the summary of this revision. (Show Details)Nov 8 2018, 3:42 PM
Habib Gahbiche (zazizizou) updated this revision to Diff 12460.Nov 8 2018, 7:01 PM
Habib Gahbiche (zazizizou) edited the summary of this revision. (Show Details)

I was overthinking this. Implementing this based on BM_face_calc_area is far simpler.

Habib Gahbiche (zazizizou) updated this revision to Diff 12461.Nov 8 2018, 7:33 PM
Habib Gahbiche (zazizizou) edited the summary of this revision. (Show Details)

take rsmat outside of loop.

Dalai Felinto (dfelinto) mentioned this in D3899: Multi-Object-Mode: SIMFACE_PERIMETER.Nov 9 2018, 12:49 PM
Habib Gahbiche (zazizizou) updated this revision to Diff 12482.Nov 9 2018, 3:11 PM

rebase and style update.

Dalai Felinto (dfelinto) added a comment.Nov 9 2018, 7:54 PM

Thanks, but by rebase I mean to fetch the latest blender2.8 and then rebase.
For instance, mesh_select_similar_compare_float_tree doesn't exist any longer in the blender2.8 code base.

Dalai Felinto (dfelinto) mentioned this in rB0c1934f3c2d3: Multi-Objects: MESH_OT_select_similar worldspace completion.Nov 9 2018, 8:19 PM
Dalai Felinto (dfelinto) accepted this revision.Nov 9 2018, 8:21 PM

Thanks, committed as rB0c1934f3c2d3dff3bce65e2e8169866bafea04e0.

This revision is now accepted and ready to land.Nov 9 2018, 8:21 PM
Dalai Felinto (dfelinto) closed this revision.Nov 9 2018, 8:22 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
mesh/
33 lines

Diff 12402

View Options

source/blender/editors/mesh/editmesh_select_similar.c

Loading...