Page MenuHome
Differential D3899

Multi-Object-Mode: SIMFACE_PERIMETER
AbandonedPublic
Actions

Authored by Habib Gahbiche (zazizizou) on Nov 6 2018, 12:16 AM.

Details

Reviewers
Dalai Felinto (dfelinto)
Maniphest Tasks
T56948: Multi-Object-Mode: Operators that need refactor on their logic
Summary

Select similar faces based on perimeter. Compute perimeter in world space. The solution is based on BM_face_calc_perimeter.

Limits:
*Threshold is used for comparison. This comes with the inherent limits of comparing floating points.

Diff Detail

Repository
rB Blender
Branch
MESH_OT_select_similar_perimeter (branched from blender2.8)
Build Status
Buildable 2405
Build 2405: arc lint + arc unit

Event Timeline

Habib Gahbiche (zazizizou) created this revision.Nov 6 2018, 12:16 AM
Habib Gahbiche (zazizizou) updated this revision to Diff 12401.Nov 6 2018, 1:31 AM

renamed function

Habib Gahbiche (zazizizou) mentioned this in D3896: Multi-Object-Mode: SIMFACE_AREA.Nov 6 2018, 1:34 AM
Habib Gahbiche (zazizizou) added a reviewer: Dalai Felinto (dfelinto).
Habib Gahbiche (zazizizou) added a task: T56948: Multi-Object-Mode: Operators that need refactor on their logic.
Habib Gahbiche (zazizizou) edited the summary of this revision. (Show Details)Nov 8 2018, 3:44 PM
Habib Gahbiche (zazizizou) updated this revision to Diff 12462.Nov 8 2018, 7:52 PM
Habib Gahbiche (zazizizou) edited the summary of this revision. (Show Details)

The solution is based on BM_face_calc_perimeter.

Dalai Felinto (dfelinto) requested changes to this revision.Nov 9 2018, 12:49 PM
Dalai Felinto (dfelinto) added a subscriber: Campbell Barton (campbellbarton).

@Campbell Barton (campbellbarton) any suggestion regarding function names?

My suggestion regarding style applies also to D3896 and D3908.

source/blender/bmesh/intern/bmesh_polygon.c
50 ↗(On Diff #12462)

Move this up, right after DNA_modifier_types.h.

259 ↗(On Diff #12462)

Leave one extra line between functions, and add a one line comment

/**
  * Calculate the perimeter of a ngon in world space.
 */
This revision now requires changes to proceed.Nov 9 2018, 12:49 PM
Dalai Felinto (dfelinto) added a comment.Nov 9 2018, 2:13 PM

(patches also need rebase since some recent change)

Habib Gahbiche (zazizizou) updated this revision to Diff 12481.Nov 9 2018, 2:51 PM

style

Dalai Felinto (dfelinto) mentioned this in rB0c1934f3c2d3: Multi-Objects: MESH_OT_select_similar worldspace completion.Nov 9 2018, 8:19 PM
Dalai Felinto (dfelinto) abandoned this revision.Nov 9 2018, 8:21 PM

Thanks, committed as rB0c1934f3c2d3dff3bce65e2e8169866bafea04e0.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
mesh/
33 lines

Diff 12401

View Options

source/blender/editors/mesh/editmesh_select_similar.c

Loading...