GPU OffsCreen to Python: New `bind_unbind` method to work in the with-block context.
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Nov 8 2018, 5:54 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Jacques Lucke (JacquesLucke)

Commits

rBS3f59bdc1bd0a: PyAPI: GPUOffscreen: Add context manager for the `bind` method to work with the…
rB3f59bdc1bd0a: PyAPI: GPUOffscreen: Add context manager for the `bind` method to work with the…

Summary

Context manager to ensure balanced bind/unbind calls, even in the case of an error.
Request from @Jacques Lucke (JacquesLucke)

Diff Detail

Repository: rB Blender

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Nov 8 2018, 5:54 PM

Campbell Barton (campbellbarton) accepted this revision.Nov 9 2018, 5:10 AM

This revision is now accepted and ready to land.Nov 9 2018, 5:10 AM

Note, we could make bind perform both bind and bind/undbind context manager, just as open(..) does for Python, apply this to matrix.push_pop.

Jacques Lucke (JacquesLucke) mentioned this in T56351: Python API (parent task).Nov 9 2018, 1:57 PM

@Germano Cavalcante (mano-wii): Can you implement the suggested changes and commit it please, so that I can update the API examples before the beta?

Make bind perform the bind/undbind context manager, just as open(..) does for Python;

Also, the __enter__ and __exit__ methods have been added to the original GPUOffscreen object type. This avoids allocating more objects and is useful if you want to do something like: