Remove confirmation dialogs for save and delete
ClosedPublic
Actions

Authored by Nathan Craddock (natecraddock) on Nov 17 2018, 9:14 AM.

Details

Reviewers

Campbell Barton (campbellbarton)
William Reynish (billreynish)

Summary

Removed popup confirmation dialogs for save and delete operators in favor of a status bar message. (See T57880)

For delete, it reports the number of deleted objects

Update:

Now pressing the delete key will not show a confirmation popup, but "X" will create a operator confirm popup.

Diff Detail

Repository: rB Blender

Event Timeline

Nathan Craddock (natecraddock) created this revision.Nov 17 2018, 9:14 AM

Nathan Craddock (natecraddock) added inline comments.Nov 17 2018, 9:20 AM

source/blender/editors/object/object_add.c
1419	It also worked with this line deleted, I'm not sure what the convention is though

William Reynish (billreynish) awarded a token.Nov 17 2018, 10:01 AM

Nathan Craddock (natecraddock) mentioned this in T57880: Remove confirmation dialogs Save or Delete, in favour of displaying messages in the Status Bar.Nov 17 2018, 4:49 PM

Duarte Farrajota Ramos (duarteframos) awarded a token.Nov 18 2018, 4:19 AM

Duarte Farrajota Ramos (duarteframos) added a subscriber: Duarte Farrajota Ramos (duarteframos).

Based on discussion on papercut task (T57880) confirmation popups are back for pressing the "X" key to delete. Pressing the delete key will not create a popup.

Personally while testing I really really enjoyed pressing "X" without a popup for deleting. It just felt so fast! But that might be just me, and the points made in the discussion considering massive amounts of objects do have merit.

I tested this, and to me this works very well. Saving not being a two-step action is a huge benefit, and the X-key vs Delete key difference seems like a good tradeoff.

@Campbell Barton (campbellbarton) Can you review the code if it's ok with you?

This revision is now accepted and ready to land.Nov 18 2018, 12:49 PM

Campbell Barton (campbellbarton) mentioned this in rB750690ae7a5c: Object: report number of deleted objects.Nov 20 2018, 12:16 AM

Campbell Barton (campbellbarton) mentioned this in rB47139c69d7e4: Keymap: only use delete confirmation for X-key.

Thanks for the patch! committed:

rB750690ae7a5c5331921dede7e62b095619154c70
- Report even when zero items are deleted - since users may have expected some result.
- Change report type to info since warning are for when things don't act as expected.
- Rename counter to changed_count, remove changed.

rB47139c69d7e46975c273a8f6981aca9e5cdda1d1
- Move confirm with check to generic, reusable API call: WM_operator_confirm_or_exec.
- Default confirm to true and remove the option from the keymap when it's true (since we can assume confirmation is useful if the operator author added it at all, turning off is the exception).