Active Curves UI point should stand out
AbandonedPublic
Actions

Authored by swann (slumber) on Nov 27 2018, 11:58 PM.

Details

Reviewers

William Reynish (billreynish)
Campbell Barton (campbellbarton)
Pablo Vazquez (pablovazquez)

Summary

A proposal for T58090.

Diff Detail

Repository: rB Blender

Event Timeline

swann (slumber) created this revision.Nov 27 2018, 11:58 PM

swann (slumber) edited the summary of this revision. (Show Details)

Duarte Farrajota Ramos (duarteframos) awarded a token.Nov 28 2018, 12:03 AM

swann (slumber) edited the summary of this revision. (Show Details)Nov 28 2018, 12:03 AM

swann (slumber) edited the summary of this revision. (Show Details)Nov 28 2018, 10:09 AM

great, though this makes the active point dark, and not so clearly visible.

Could we use the selected vertex color, for example? Or do we just solve this in the theme?

@Pablo Vazquez (pablovazquez) : thoughts?

Thanks for the feedback !
I am making it use the selected vertex color.
I will post an update soon !

Added a new function to retrieve theme color (scaled to 0.0-1.0 range) given a space type and a color id.
Setup curve and color ramp active item to use the vertex_select theme color.

swann (slumber) mentioned this in T58090: Active Curves UI point should stand out.Nov 29 2018, 12:40 PM

Fantastic. Looks good to me.

@Pablo Vazquez (pablovazquez) Can you check if this is ok?

Agree with changing the Cureve map. However, the Color Ramp colors should remain neutral here as the handles are colored to reflect the actual color of the stop,

Ah nice! Looks good to me too.

BTW that function comes in very handy!

@Pablo Vazquez (pablovazquez) @Brecht Van Lommel (brecht) this seems good to me - can any of you check and commit if you accept?

So the last version is using TH_TEXT, and TH_VERTEX_SELECT when a vertex is active? Why not VERTEX and VERTEX_SELECT?

@Pablo Vazquez (pablovazquez) I have been testing with TH_VERTEX witch is black in the default theme:

so I suggest to left the TH_TEXT color for a better visibility of inactive curve points.
I could change to TH_VERTEX or another theme color if you prefer.

@Pablo Vazquez (pablovazquez) feel free to tell me if the diff need any change, I would be happy to work on it.

@Pablo Vazquez (pablovazquez) can you take a look at this?

TH_TEXT sounds okay to me. Time to send it to the devs for review!

William Reynish (billreynish) added reviewers: Campbell Barton (campbellbarton), Pablo Vazquez (pablovazquez).Feb 15 2019, 1:03 AM

Campbell Barton (campbellbarton) mentioned this in rB796abc90a8ba: Fix T58090: Selected curve vertex should stand out.Feb 15 2019, 2:05 AM

It's unreliable to mix 3D view and UI widget colors,
I've committed a change that uses text color, blending it with the background in the case both colors match.

This works with both blender light and dark theme colors.

We can always tweak the contrast (it might be a a little low at the moment)

Noticed this patch also changes color band, but it's using 3D view colors too.

Closing, other changes can be submitted as separate patches.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

interface/

interface_draw.c

13 lines

Diff 12691

View Options

source/blender/editors/interface/interface_draw.c

Active Curves UI point should stand outAbandonedPublicActions