Page MenuHome
Differential D4036

GP: Refactor coordinates to float
ClosedPublic
Actions

Authored by Charlie Jolly (charlie) on Dec 5 2018, 7:48 PM.

Details

Reviewers
Antonio Vazquez (antoniov)
Group Reviewers
Grease Pencil
Commits
rBSad47b0236e32: GP: Refactor coordinates to float
rB1b1b28f4bd36: GP: Refactor coordinates to float
rBad47b0236e32: GP: Refactor coordinates to float
Summary

See: D4030

Diff Detail

Repository
rB Blender
Branch
blender2.8
Build Status
Buildable 2587
Build 2587: arc lint + arc unit

Event Timeline

Charlie Jolly (charlie) created this revision.Dec 5 2018, 7:48 PM
Charlie Jolly (charlie) added reviewers: Antonio Vazquez (antoniov), Grease Pencil.Dec 5 2018, 7:55 PM
Charlie Jolly (charlie) added a subscriber: Antonio Vazquez (antoniov).

This patch changes the point storage to floats. The changes are limited to GP only. Not touched ED_ or BLI_ functions. This does mean that there are quite a few casts but from my limited testing I've not had any issues so far.

@Antonio Vazquez (antoniov) If you could take a look that would be appreciated. I won't be around until tomorrow to follow up.

Antonio Vazquez (antoniov) added inline comments.Dec 5 2018, 8:30 PM
source/blender/editors/gpencil/gpencil_paint.c
1364

Colud you calc mval_i outside of the loop?

1390

Same as above (calc outside loop)

Antonio Vazquez (antoniov) added a comment.Dec 5 2018, 8:36 PM

The changes look good in general, only review that you calc the integer conversion only once and try to use only one variable definition. Really, this is not an issue running the code, but makes it more clear.

source/blender/editors/gpencil/annotate_paint.c
812

Maybe you could calc mval_i at the begining of the function.

Antonio Vazquez (antoniov) requested changes to this revision.Dec 5 2018, 8:36 PM
This revision now requires changes to proceed.Dec 5 2018, 8:36 PM
Charlie Jolly (charlie) updated this revision to Diff 12787.Dec 6 2018, 4:22 PM
Charlie Jolly (charlie) marked 3 inline comments as done.

Fix GPU format and address comments

Charlie Jolly (charlie) updated this revision to Diff 12788.Dec 6 2018, 4:32 PM

Git issue, lost some changes

Antonio Vazquez (antoniov) accepted this revision.Dec 7 2018, 8:24 AM

@Charlie Jolly (charlie) Commit in 2.8 and then merge to greasepencil-object to keep the branch updated to last version.

This revision is now accepted and ready to land.Dec 7 2018, 8:24 AM
Charlie Jolly (charlie) updated this revision to Diff 12803.Dec 7 2018, 12:20 PM

Fixed issue with cursor, was customdata cast as int

Closed by commit rBad47b0236e32: GP: Refactor coordinates to float (authored by Charlie Jolly (charlie)). · Explain WhyDec 7 2018, 12:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
gpencil/
10 lines
55 lines
16 lines
12 lines
12 lines
9 lines
114 lines
18 lines
4 lines
48 lines
include/
15 lines

Diff 12772

View Options

source/blender/editors/gpencil/annotate_draw.c

Loading...
View Options

source/blender/editors/gpencil/annotate_paint.c

Loading...
View Options

source/blender/editors/gpencil/drawgpencil.c

Loading...
View Options

source/blender/editors/gpencil/gpencil_brush.c

Loading...
View Options

source/blender/editors/gpencil/gpencil_fill.c

Loading...
View Options

source/blender/editors/gpencil/gpencil_intern.h

Loading...
View Options

source/blender/editors/gpencil/gpencil_paint.c

Loading...
View Options

source/blender/editors/gpencil/gpencil_primitive.c

Loading...
View Options

source/blender/editors/gpencil/gpencil_select.c

Loading...
View Options

source/blender/editors/gpencil/gpencil_utils.c

Loading...
View Options

source/blender/editors/include/ED_gpencil.h

Loading...