Paths

Table of Contentst

Differential D4065

Implement BMesh.from_object
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Dec 11 2018, 1:58 PM.

Tags

None

Subscribers

None

Details

Reviewers

Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)

Maniphest Tasks

T59069: Python: Bmesh "from_object" broken in 2.8

Commits

rBSeb83efb6d1bb: Implement BMesh.from_object
rBeb83efb6d1bb: Implement BMesh.from_object

Summary

Fixes T59069

Diff Detail

Repository

Branch

T59069 (branched from blender2.8)

Build Status

Buildable 2616
Build 2616: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Dec 11 2018, 1:58 PM

Harbormaster completed remote builds in B2614: Diff 12854.Dec 11 2018, 1:58 PM

Brecht Van Lommel (brecht) accepted this revision.Dec 11 2018, 2:24 PM

Brecht Van Lommel (brecht) added inline comments.

source/blender/python/bmesh/bmesh_py_types.c
1007–1008	It's not a new issue, but it seems cage mode is not supported regardless of the value of `use_render`, so this is a bit confusing. It should just say "cage arg is unsupported when deform=False", and the code could be simplified to: if (use_cage) else if (use_render) else

This revision is now accepted and ready to land.Dec 11 2018, 2:24 PM

review by brecht

Harbormaster completed remote builds in B2616: Diff 12857.Dec 11 2018, 3:12 PM

Philipp Oeser (lichtwerk) marked an inline comment as done.Dec 11 2018, 3:13 PM

Brecht Van Lommel (brecht) accepted this revision.Dec 11 2018, 3:13 PM

Closed by commit rBeb83efb6d1bb: Implement BMesh.from_object (authored by Philipp Oeser (lichtwerk)). · Explain WhyDec 11 2018, 3:23 PM

This revision was automatically updated to reflect the committed changes.

Jon Denning (gfxcoder) mentioned this in T89013: Bmesh: removed deform parameter of from_object still in PyDoc.Jun 9 2021, 11:40 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

python/

bmesh/

bmesh_py_types.c

79 lines

Diff 12857

source/blender/python/bmesh/bmesh_py_types.c

Loading...