FBX export: skip special properties when exporting custom properties
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Dec 12 2018, 11:29 AM.

Details

Reviewers

Bastien Montagne (mont29)

Maniphest Tasks

T59202: FBX Custom property error

Commits

rBA3a264229d2d3: FBX export: skip special properties when exporting custom properties
rBAe4f4053de64e: FBX export: skip special properties when exporting custom properties

Summary

'_RNA_UI' (and rna runtime properties) should not be included, these
would have been included as string properties causing errors on reimport

Fixes T59202

Diff Detail

Repository: rBA Blender Add-ons

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Dec 12 2018, 11:29 AM

I have excluded rna properties as well [even though I am not 100% sure this is the right thing to do?]

Do we want to keep stuff like {'cycles_visibility', 'cycles'}?

Also sorry for not using arc (but for some reason arc is acting up [hanging/freezing] in Addons for me atm...)

Besides comments below, patch lgtm

io_scene_fbx/export_fbx_bin.py
538	Just do early return if items is empty, much simpler ;)
541	I would consider excluding any prop which name starts with `_`, so something like that instead: `if not k or k[:1] == "_" or k in rna_properties:`

This revision is now accepted and ready to land.Dec 12 2018, 11:46 AM

In D4068#92044, @Philipp Oeser (lichtwerk) wrote:

Do we want to keep stuff like {'cycles_visibility', 'cycles'}?

{'cycles_visibility', 'cycles'} and similar stuff can be also thrown away I think...It only create mess in the custom properties when loaded in other 3D software

Philipp Oeser (lichtwerk) added inline comments.Dec 12 2018, 12:32 PM

io_scene_fbx/export_fbx_bin.py
541	not sure... I think we could/should be specific about stuff that causes problems from the blender side of things, but otherwise not enforce too much on the user... (it's possible a pipeline defines props with "_" prefix that should be kept -- even though not the best practice...)