Differential D4080
Multi-Object EditMode: LATTICE_OT_flip Authored by Habib Gahbiche (zazizizou) on Dec 14 2018, 7:09 PM. Tags None Subscribers None
Details LATTICE_OT_flip now uses global symmetry axis. This is done in 3 steps.
Diff Detail
Event TimelineComment Actions Crashed in simple test:
SUMMARY: AddressSanitizer: heap-buffer-overflow /home/dfelinto/src/blender/blender/source/blender/blenlib/intern/math_vector_inline.c:260 in swap_v3_v3 {*} - (otherwise the second object won't be selected - unrelated bug, a bug nonetheless if you want to investigate it separately go ahead) Comment Actions Also I skimmed over it, but I'm a bit skeptical at the length of the new code. It seems surprisingly more lengthy than the original one. Comment Actions Can't reproduce. But maybe because I'm not building with everything enabled. I'll investigate more...
For me it behaves as expected (?), i.e. If you scale in x-direction by -1 you would get the same result. Or maybe you're getting something related to (*)? The function lattice_swap_indices() is what makes the code much larger. The original code does the mirroring and index swapping at once in one step. Here, I need to do the mirroring globally (because axis is now global), and the index swapping locally. Hence the extra code. Comment Actions
Are you Linux? If so you can build with WITH_COMPILER_ASAN to catch those. Comment Actions Updated patch such that it can be applied to current master. Comment Actions Please keep the patch to a minimum. There are way too many cosmetic changes that do not belong here.
Comment Actions Can we first agree that this patch produces the expected behavior before continuing with the review of the code itself? For instance the check for rotation was introduced and the check for odd/even numbers of points was eliminated. The attached blend file shows what this patch produces vs. what I would have expected for 3 cases. I cannot produce a case where the normals are flipped (sphere would look much smaller or squashed) when both lattices are rotated. | |||||||||||||