Paths

Table of Contentst

Differential D4081

Fix T59351: bypass texture creation test with GL_PROXY.. on AMD graphics cards.
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Dec 14 2018, 9:47 PM.

Tags

None

Subscribers

Benjamin Humpherys (brhumphe)

Details

Reviewers

Clément Foucault (fclem)

Commits

rBSba1f178c1c85: Fix T56185, T59351: bypass GL_PROXY_TEXTURE.. test on AMD GPU + windows
rBba1f178c1c85: Fix T56185, T59351: bypass GL_PROXY_TEXTURE.. test on AMD GPU + windows

Summary

Some AMD drivers have a faulty GL_PROXY_TEXTURE_.. check.

This patch replaces the test of consistency and capacity made with GL_PROXY_TEXTURE_.. in the AMD driver with one that checks only if the texture fits within the size and layer limits.
I was unable to determine which cards have this defect, but since rB141e94f87ff2 fixes a similar problem and applies to all AMD GPUs, this patch also applies to all.

Diff Detail

Repository

Branch

blender2.8_bypass_proxy_textures (branched from blender2.8)

Build Status

Buildable 2633
Build 2633: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Dec 14 2018, 9:47 PM

Harbormaster completed remote builds in B2632: Diff 12913.Dec 14 2018, 9:47 PM

Cleanup: remove GPU_proxy_texture_workaround func.

Harbormaster completed remote builds in B2633: Diff 12914.Dec 14 2018, 10:11 PM

Tested this on de662e7cd3b and it does seem to resolve T59351.

Clément Foucault (fclem) added inline comments.Dec 15 2018, 12:51 AM

source/blender/gpu/intern/gpu_texture.c
487	I think for now we only encountered this problem on windows. I would limit this fix to windows only.

Limit workaround to windows

Harbormaster completed remote builds in B2634: Diff 12916.Dec 15 2018, 1:17 AM

Remove unnecessary editing in comment

Harbormaster completed remote builds in B2635: Diff 12917.Dec 15 2018, 1:19 AM

Germano Cavalcante (mano-wii) marked an inline comment as done.Dec 15 2018, 1:19 AM

Clément Foucault (fclem) accepted this revision.Dec 15 2018, 1:20 AM

This revision is now accepted and ready to land.Dec 15 2018, 1:20 AM

Closed by commit rBba1f178c1c85: Fix T56185, T59351: bypass GL_PROXY_TEXTURE.. test on AMD GPU + windows (authored by Germano Cavalcante (mano-wii)). · Explain WhyDec 15 2018, 1:35 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

gpu/

intern/

gpu_extensions.c

4 lines

107 lines

Diff 12914

source/blender/gpu/intern/gpu_extensions.c

Loading...

source/blender/gpu/intern/gpu_texture.c

Loading...