Differential D4090

Fix T59424: Color wheel snaps to center: loosing hue if light value is down to zero.
ClosedPublic
Actions

Authored by Sebastian Parborg (zeddb) on Dec 17 2018, 6:50 PM.

Tags

None

Subscribers

None

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rBS1eafa91f6471: Fix T59424: color wheel snaps to center, losing hue when value is zero.
rB1eafa91f6471: Fix T59424: color wheel snaps to center, losing hue when value is zero.

Summary

It seems like the original code tried to prevent this (h,s values getting set to zero with low v values), but because of floats, v never became exactly zero or less.

During my tests it seems like the change in s value happened when v took on a value of 4.86969043e-09
I've tested this by putting in values in the UI color wheel. It seems to work fine now.

Diff Detail

Repository: rB Blender

Event Timeline

Sebastian Parborg (zeddb) created this revision.Dec 17 2018, 6:50 PM

Sebastian Parborg (zeddb) edited the summary of this revision. (Show Details)

Sebastian Parborg (zeddb) mentioned this in T59424: Color wheel snaps to center: loosing hue if light value is down to zero..

Thanks!

This revision is now accepted and ready to land.Dec 17 2018, 7:16 PM

Closed by commit rB1eafa91f6471: Fix T59424: color wheel snaps to center, losing hue when value is zero. (authored by Sebastian Parborg (zeddb), committed by Brecht Van Lommel (brecht)). · Explain WhyDec 17 2018, 7:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenlib/

intern/

5 lines

Diff 12944

source/blender/blenlib/intern/math_color.c

Loading...