Fix T59500: Weight Smoothing Not Working
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Dec 18 2018, 11:22 AM.

Details

Reviewers

Brecht Van Lommel (brecht)
Dalai Felinto (dfelinto)

Maniphest Tasks

T59500: Weight Smoothing Not Working in 2.80

Commits

rBSbc8f2e9ee42b: Fix T59500: Weight Smoothing Not Working
rBbc8f2e9ee42b: Fix T59500: Weight Smoothing Not Working

Diff Detail

Repository

rB Blender

Branch

T59500 (branched from blender2.8)

Build Status

Buildable 2654
Build 2654: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Dec 18 2018, 11:22 AM

Harbormaster completed remote builds in B2644: Diff 12954.Dec 18 2018, 11:23 AM

The vertex_group_vert_poll_ex poll function allows this operator to run in both edit and weight paint mode.

So I guess it should do something different depending on the mode, not just work for one or the other.

This revision now requires changes to proceed.Dec 18 2018, 3:19 PM

allow both editmode and weight paint mode

Harbormaster completed remote builds in B2648: Diff 12963.Dec 18 2018, 3:53 PM

seems to do the same thing, so just allow both modes?

It's not clear to me that this function is intended to take multiple modes?

To be sure I would pass it ob->mode from the same object used in the poll function.

review by brecht

Harbormaster completed remote builds in B2654: Diff 12972.Dec 19 2018, 9:22 AM

Brecht Van Lommel (brecht) accepted this revision.Dec 19 2018, 10:53 AM

This revision is now accepted and ready to land.Dec 19 2018, 10:53 AM

Closed by commit rBbc8f2e9ee42b: Fix T59500: Weight Smoothing Not Working (authored by Philipp Oeser (lichtwerk)). · Explain WhyDec 19 2018, 11:55 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

object/

object_vgroup.c

4 lines

Diff 12972

View Options

source/blender/editors/object/object_vgroup.c

Fix T59500: Weight Smoothing Not WorkingClosedPublicActions