Paths

Table of Contentst

Differential D4097

Fix T59536: safe area values were swapped
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Dec 18 2018, 2:30 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Commits

rBS5fa749ace29a: Fix T59536: safe area values were swapped
rB5fa749ace29a: Fix T59536: safe area values were swapped

Summary

This only changes the values for new scenes, I wonder if versioning code can fix this in a good way. It's not a big deal though because Blender always shows both safe areas anyway. Only the default scene should be updated at some point.

Diff Detail

Repository

rB Blender

Branch

safe_areas (branched from blender2.8)

Build Status

Buildable 2647
Build 2647: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Dec 18 2018, 2:30 PM

Harbormaster completed remote builds in B2646: Diff 12956.Dec 18 2018, 2:30 PM

Jacques Lucke (JacquesLucke) mentioned this in T59536: Wrong Camera Safe Areas: The default values of Title Safe Margins and Action Safe Margins replace each other.Dec 18 2018, 2:30 PM

You can change the default scene values in BLO_update_defaults_startup_blend. Otherwise looks good to me.

change default safe areas when loading default file

Thanks, that is what I was looking for.

Harbormaster completed remote builds in B2647: Diff 12959.Dec 18 2018, 3:17 PM

Brecht Van Lommel (brecht) accepted this revision.Dec 18 2018, 3:20 PM

This revision is now accepted and ready to land.Dec 18 2018, 3:20 PM

Closed by commit rB5fa749ace29a: Fix T59536: safe area values were swapped (authored by Jacques Lucke (JacquesLucke)). · Explain WhyDec 18 2018, 3:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

scene.c

4 lines

blenloader/

intern/

versioning_defaults.c

2 lines

makesrna/

intern/

rna_scene.c

4 lines

Diff 12959

View Options

source/blender/blenkernel/intern/scene.c

View Options

source/blender/blenloader/intern/versioning_defaults.c

View Options

source/blender/makesrna/intern/rna_scene.c

Fix T59536: safe area values were swappedClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 12959

source/blender/blenkernel/intern/scene.c

source/blender/blenloader/intern/versioning_defaults.c

source/blender/makesrna/intern/rna_scene.c

Fix T59536: safe area values were swapped
ClosedPublic
Actions

Revision Contents
Changeset List