Fix T57777: Decimate modifier face count does not work
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Dec 19 2018, 4:48 PM.

Details

Reviewers

Sergey Sharybin (sergey)
Brecht Van Lommel (brecht)

Commits

rBSc02f67fa8ae5: Fix T57777: Decimate modifier face count does not work
rBc02f67fa8ae5: Fix T57777: Decimate modifier face count does not work

Summary

Is that the right way to hack the COW system? :D

Diff Detail

Repository

rB Blender

Branch

decimate_face_count (branched from blender2.8)

Build Status

Buildable 2661
Build 2661: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Dec 19 2018, 4:48 PM

Harbormaster completed remote builds in B2661: Diff 12986.Dec 19 2018, 4:48 PM

Jacques Lucke (JacquesLucke) mentioned this in T57777: Face count decimate modifier not work.Dec 19 2018, 4:48 PM

Jacques Lucke (JacquesLucke) added a reviewer: Brecht Van Lommel (brecht).Dec 19 2018, 6:09 PM

It should only write back when evaluating the active depsgraph (DEG_is_active(depsgraph)), not the one for rendering for example.

Otherwise seems fine.

This revision now requires changes to proceed.Dec 19 2018, 6:30 PM

only update when depsgraph is active

Harbormaster completed remote builds in B2664: Diff 12995.Dec 20 2018, 11:05 AM

Brecht Van Lommel (brecht) accepted this revision.Dec 20 2018, 11:09 AM

This revision is now accepted and ready to land.Dec 20 2018, 11:09 AM

Closed by commit rBc02f67fa8ae5: Fix T57777: Decimate modifier face count does not work (authored by Jacques Lucke (JacquesLucke)). · Explain WhyDec 20 2018, 11:18 AM

This revision was automatically updated to reflect the committed changes.

Sebastian Parborg (zeddb) mentioned this in T59708: decimate modifier do not show the polycount before decimation.Dec 21 2018, 2:38 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

modifiers/

intern/

MOD_decimate.c

12 lines

Diff 12986

View Options

source/blender/modifiers/intern/MOD_decimate.c

Fix T57777: Decimate modifier face count does not workClosedPublicActions