UI: Shrink + buttons to open Toolbar & Sidebar in the Viewport & Text Editor
ClosedPublic
Actions

Authored by Nico Zevallos (gnastacast) on Dec 19 2018, 11:37 PM.

Details

Reviewers

William Reynish (billreynish)
Campbell Barton (campbellbarton)

Maniphest Tasks

T57749: Shrink + buttons to open Toolbar & Sidebar in the Viewport & Text Editor

Summary

Turned plus signs that hide or show toolbars and headers into arrows so that they take up less space and don't overlap other items.
Closes T57749
Part of UI Paper Cuts T56950

Diff Detail

Event Timeline

Nico Zevallos (gnastacast) created this revision.Dec 19 2018, 11:37 PM

Nico Zevallos (gnastacast) added reviewers: William Reynish (billreynish), Campbell Barton (campbellbarton).

Do you have an image?

This doesn't show anything:

when hiding the navigation (tabs) in the buttons window.
when hiding the header in the outliner and buttons window.

This revision now requires changes to proceed.Dec 19 2018, 11:45 PM

I also see an error I made creating two useless x,y variables. I think it needs a cleanup anyway, this is just my first pass.

buttons window

Could you clarify where the buttons window is? Is that the toolbox on the left?

In D4110#93093, @Nico Zevallos (gnastacast) wrote:

buttons window

Could you clarify where the buttons window is? Is that the toolbox on the left?

'Buttons Window' is a funny old term for the Properties Editor.

as you can see in this image, it works for the header in the properties window and the outliner on Linux. How do I hide the tabs in the properties window?

In D4110#93095, @Nico Zevallos (gnastacast) wrote:

as you can see in this image, it works for the header in the properties window and the outliner on Linux. How do I hide the tabs in the properties window?

You hide them by dragging the tab area closed.

If the issues can be worked out, the design of these look good to me.

@Nico Zevallos (gnastacast), tested again and confirmed it works with headers now (strange! edit: was uninitialized variable).

Still failing w/ tabs as noted by @William Reynish (billreynish) and toolbar (T-Key in 3D view).

In D4110#93097, @Campbell Barton (campbellbarton) wrote:

@Nico Zevallos (gnastacast), tested again and confirmed it works with headers now (strange!).

Still failing w/ tabs as noted by @William Reynish (billreynish) and toolbar (T-Key in 3D view).

Hmm. Both work on my end. I think it may have something to do with the 'add' variable. I'll take a look tomorrow. What operating system are you testing these on?

Fixed uninitialized variable 'add' and removed unnecessary variables x,y

Added comments and cleared extra tabs.

Got rid of the 'add' variable for tabs on the left edges. The '-1' that was being added made the tabs asymmetrical.

Campbell Barton (campbellbarton) accepted this revision.Dec 20 2018, 11:14 PM

This revision is now accepted and ready to land.Dec 20 2018, 11:14 PM

Campbell Barton (campbellbarton) mentioned this in rBdb410385b78a: UI: use smaller widget for expanding hidden region.Dec 20 2018, 11:14 PM

Thanks! Committed w/ minor changes rBdb410385b78a5e115395df1daf44feb401a5a4ef