Page MenuHome
Differential D4113

Fix T59675: Motion path frame numbers at wrong positions
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Dec 20 2018, 3:01 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Joshua Leung (aligorith)
Commits
rBS07569a333b2e: Fix T59675: Motion path frame numbers at wrong positions
rB07569a333b2e: Fix T59675: Motion path frame numbers at wrong positions
Summary

I don't really understand why the positions were multiplied with ob->imat.
It worked in some cases because ob->imat was not updated at that point (I think).

Motion path coordinates are always in world space, right?

Diff Detail

Repository
rB Blender
Branch
motion_path_text (branched from blender2.8)
Build Status
Buildable 2668
Build 2668: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Dec 20 2018, 3:01 PM
Harbormaster completed remote builds in B2668: Diff 13003.Dec 20 2018, 3:01 PM
Jacques Lucke (JacquesLucke) mentioned this in T59675: Motion path incorrectly displays the number of frames and key frames..Dec 20 2018, 3:02 PM
Brecht Van Lommel (brecht) accepted this revision.Dec 21 2018, 6:05 PM

I can't see a reason for this use of ob->imat either.

This revision is now accepted and ready to land.Dec 21 2018, 6:05 PM
Closed by commit rB07569a333b2e: Fix T59675: Motion path frame numbers at wrong positions (authored by Jacques Lucke (JacquesLucke)). · Explain WhyDec 29 2018, 6:54 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
intern/
7 lines

Diff 13003

View Options

source/blender/draw/intern/draw_anim_viz.c

Loading...