Page MenuHome
Differential D4117

cleanup: remove unused passes
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Dec 21 2018, 11:53 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rBS2c196de56bbb: cleanup: remove unused passes
rB2c196de56bbb: cleanup: remove unused passes
Summary
  • use_pass_indirect, use_pass_specular from ViewLayer RNA (should be safe?)
  • RGBA, DIFFUSE, SPEC, REFLECT, REFRACT, INDIRECT from all over (not sure, especially DNA handling and the freestyle case...)

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Dec 21 2018, 11:53 PM
Harbormaster completed remote builds in B2672: Diff 13018.Dec 21 2018, 11:53 PM
Philipp Oeser (lichtwerk) added a comment.Dec 21 2018, 11:56 PM

Pretty unsafe territory for me, but had a go (and removed a little more) following:

In D4115#93219, @Brecht Van Lommel (brecht) wrote:
In D4115#93216, @Philipp Oeser (lichtwerk) wrote:

also noticed we still have use_pass_indirect and use_pass_specular hanging around, could/should this be removed from ViewLayer RNA?

Yes, these can be removed.

Brecht Van Lommel (brecht) accepted this revision.Dec 27 2018, 2:42 PM

Mostly fine, just one thing to fix.

source/blender/freestyle/intern/blender_interface/FRS_freestyle.cpp
450–451

This should only check RE_PASSNAME_DIFFUSE_COLOR.

Now it will end up using whichever of the 3 was last in the passes list.

This revision is now accepted and ready to land.Dec 27 2018, 2:42 PM
Closed by commit rB2c196de56bbb: cleanup: remove unused passes (authored by Philipp Oeser (lichtwerk)). · Explain WhyDec 27 2018, 3:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
freestyle/
intern/
blender_interface/
2 lines
makesdna/
18 lines
makesrna/
intern/
5 lines
12 lines
nodes/
composite/
nodes/
10 lines
render/
intern/
source/
9 lines
6 lines
18 lines

Diff 13039

View Options

source/blender/freestyle/intern/blender_interface/FRS_freestyle.cpp

Loading...
View Options

source/blender/makesdna/DNA_scene_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_render.c

Loading...
View Options

source/blender/makesrna/intern/rna_scene.c

Loading...
View Options

source/blender/nodes/composite/nodes/node_composite_image.c

Loading...
View Options

source/blender/render/intern/source/bake_api.c

Loading...
View Options

source/blender/render/intern/source/pipeline.c

Loading...
View Options

source/blender/render/intern/source/render_result.c

Loading...