Page MenuHome
Differential D4150

UV Editor, additional Pixel snapping modes
ClosedPublic
Actions

Authored by Joep Peters (Joep) on Jan 1 2019, 12:22 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)
Pablo Vazquez (pablovazquez)
Commits
rBS1651879d3419: UV Editor: support snapping to center of pixels, in addition to corners.
rB1651879d3419: UV Editor: support snapping to center of pixels, in addition to corners.
Summary

This revision adds functionality to choose either between corner, center or no pixel snapping while editing UVs. It replaces the current Snap to Pixels feature (which only snaps to corners) and makes the SI_PIXELSNAP flag deprecated.

Diff Detail

Repository
rB Blender

Event Timeline

Joep Peters (Joep) created this revision.Jan 1 2019, 12:22 PM
Joep Peters (Joep) edited the summary of this revision. (Show Details)Jan 1 2019, 3:48 PM
Joep Peters (Joep) updated this revision to Diff 13100.Jan 3 2019, 3:22 PM

The calculation of offset has to be done only once, moved it out of the for loop.

Joep Peters (Joep) added projects: User Interface, BF Blender: 2.8.Jan 22 2019, 1:01 PM
Joep Peters (Joep) edited projects, added BF Blender; removed BF Blender: 2.8.Jan 22 2019, 3:32 PM
Joep Peters (Joep) added a reviewer: Pablo Vazquez (pablovazquez).Jan 22 2019, 3:43 PM
Brecht Van Lommel (brecht) accepted this revision.Jan 22 2019, 5:03 PM

I'll commit with some tweaks.

This revision is now accepted and ready to land.Jan 22 2019, 5:03 PM
Closed by commit rB1651879d3419: UV Editor: support snapping to center of pixels, in addition to corners. (authored by Joep Peters (Joep), committed by Brecht Van Lommel (brecht)). · Explain WhyJan 22 2019, 5:06 PM
This revision was automatically updated to reflect the committed changes.
Joep Peters (Joep) added a comment.Jan 22 2019, 5:10 PM

@Brecht Van Lommel (brecht) Thank you for your review! I'm super happy now! :)

William Reynish (billreynish) added a subscriber: William Reynish (billreynish).Jan 22 2019, 5:16 PM

Why would you want to snap to the center of a pixel?

Duarte Farrajota Ramos (duarteframos) awarded a token.Jan 22 2019, 5:54 PM
Duarte Farrajota Ramos (duarteframos) added a subscriber: Duarte Farrajota Ramos (duarteframos).
Andrei Nadin (AnadinX) added a subscriber: Andrei Nadin (AnadinX).EditedJan 23 2019, 5:40 AM
In D4150#95848, @William Reynish (billreynish) wrote:

Why would you want to snap to the center of a pixel?

I'm really glad to see this and from a game dev point of view its really useful with low res textures and allowing for floating point inaccuracy

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
11 lines
source/
blender/
editors/
transform/
23 lines
makesdna/
12 lines
makesrna/
intern/
14 lines

Diff 13100

View Options

release/scripts/startup/bl_ui/space_image.py

Loading...
View Options

source/blender/editors/transform/transform_conversions.c

Loading...
View Options

source/blender/makesdna/DNA_space_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_space.c

Loading...