Fix T60098: Cycles does not respect the texture alpha mode
AbandonedPublic
Actions

Authored by Sebastian Parborg (zeddb) on Jan 3 2019, 1:21 AM.

Details

Reviewers

Summary

This is my initial take on this issue. Of course there is still a bit left to do so I do not expect this to be accepted as is.

First of all, perhaps we should merge use_alpha and alpha_mode into one enum flag?
IE:

0 = !use_alpha
1 = use_alpha && strait
2 = use_alpha && pre...

If not, where should I add the enums for alpha_mode?

I also noticed that a check in image.cpp seems redundant as it will never trigger (?). I've marked it as TODO

Additionally, this patch doesn't work with packed images. Is the cycles textures not reloaded properly?

Diff Detail

Event Timeline

Sebastian Parborg (zeddb) created this revision.Jan 3 2019, 1:21 AM

Sebastian Parborg (zeddb) mentioned this in T60098: Cycles does not respect the texture alpha mode.

Sebastian Parborg (zeddb) edited the summary of this revision. (Show Details)Jan 3 2019, 1:29 AM

Demeter Dzadik (Mets) added a subscriber: Demeter Dzadik (Mets).Jan 17 2019, 4:39 AM

Hidde Jansen (hjansen) added a subscriber: Hidde Jansen (hjansen).Jan 21 2019, 2:21 PM

Updated to use enums.

Still not working as intended with baked textures though...

Sebastian Parborg (zeddb) updated this revision to Diff 13281.Jan 21 2019, 4:52 PM

I've now updated the patch to take the alpha setting into account for baked textures as well.

Emir Sinan Gürlek (filibis) added a subscriber: Emir Sinan Gürlek (filibis).Apr 23 2019, 10:53 PM

There were a lot of code changes recently in this area, but this specific issue is still not solved I think. Basically we still rely on Cycles to auto detect the alpha mode of the final rather than following Blender.

This patch is not quite correct though. Two things to take into account.

The alpha mode is what we need to convert from.
oiio:UnassociatedAlpha control if OIIO will automatically associate alpha when file formats with non-associated alpha. If we want to follow the Blender settings exactly, we must never use this auto detection.

This revision now requires changes to proceed.Jun 6 2019, 6:16 PM

Sebastian Parborg (zeddb) abandoned this revision.Jan 17 2020, 4:55 PM

Emir Sinan Gürlek (filibis) removed a subscriber: Emir Sinan Gürlek (filibis).Jan 17 2020, 10:10 PM