Page MenuHome
Differential D4167

Fix workbench shading pie menu
AbandonedPublic
Actions

Authored by Dalai Felinto (dfelinto) on Jan 4 2019, 3:11 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Bastien Montagne (mont29)
Brecht Van Lommel (brecht)
Summary

Not all render engines have material or rendered mode.

Note: This is not working at the moment, submitting for review to get some light shed on it.

How to reproduce the original (unreported issue):

  • Change render engine to Workbench.
  • Press "Z" in the viewport for the shading menu.

Once this is out of the way a similar fix should be applied to the extended menu as well.
The problem with this patch is that I seem to always get all modes (MATERIAL included) in:

  • view.shading.bl_rna.properties["type"].enum_items

Diff Detail

Repository
rB Blender
Branch
temp-fix-workbench-shading-menu (branched from master)
Build Status
Buildable 2702
Build 2702: arc lint + arc unit

Event Timeline

Dalai Felinto (dfelinto) created this revision.Jan 4 2019, 3:11 PM
Harbormaster completed remote builds in B2702: Diff 13111.Jan 4 2019, 3:11 PM
Dalai Felinto (dfelinto) mentioned this in T60123: Memory leak and crash when playing with X-ray value in Wireframe mode.Jan 4 2019, 3:12 PM
Bastien Montagne (mont29) added a comment.Jan 4 2019, 7:11 PM

Well, C RNA code expects MATERIAL to be valid for all renderers. Only RENDERED is optional (see rna_space.c, rna_3DViewShading_type_itemf() func)…

Dalai Felinto (dfelinto) added a comment.Jan 4 2019, 7:14 PM
In D4167#94185, @Bastien Montagne (mont29) wrote:

Well, C RNA code expects MATERIAL to be valid for all renderers. Only RENDERED is optional (see rna_space.c, rna_3DViewShading_type_itemf() func)…

Not really. look at the logic for BKE_scene_uses_blender_workbench() there. There is no MATERIAL for benchmark engine.

Bastien Montagne (mont29) added a comment.Jan 4 2019, 7:18 PM

Then you have to update RNA code to match expected behavior :P

Dalai Felinto (dfelinto) added a comment.Jan 4 2019, 7:59 PM

C'mon I'm serious here :) The RNA as far as everythign else is concerned seems to be working fine, so I'm either using the wrong API to access the items, or we need to define them differently.

Campbell Barton (campbellbarton) abandoned this revision.Jan 8 2019, 7:19 AM

Committed fix rB859a4dd51b824f4210c8a85ea3769995ac35cd4c

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
7 lines

Diff 13111

View Options

release/scripts/startup/bl_ui/space_view3d.py

Loading...