Page MenuHome
Differential D4241

Switch to new style objects in Python
AbandonedPublic
Actions

Authored by Rasmus Petersen (yoff) on Jan 23 2019, 6:16 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Summary

We are using old style objects in a few places, but also using the slots feature which is only available for new style objects.

See for instance this alert the small help icon to the far right links to a more detailed explanation.

These were found using LGTM.com, the producers of which I now happen to work for. I would be happy, if it could turn out to be useful for blender :-)

I just assigned a single reviewer, feel free to push this around...

Diff Detail

Event Timeline

Rasmus Petersen (yoff) created this revision.Jan 23 2019, 6:16 PM
Rasmus Petersen (yoff) edited the summary of this revision. (Show Details)
Rasmus Petersen (yoff) added a reviewer: Campbell Barton (campbellbarton).
Campbell Barton (campbellbarton) abandoned this revision.Jan 24 2019, 2:38 AM

Old-style classes are removed in Python 3, leaving only new-style classes.

https://docs.python.org/2/reference/datamodel.html#new-style-and-classic-classes

Rasmus Petersen (yoff) added a comment.Jan 24 2019, 8:37 AM

Old-style classes are removed in Python 3, leaving only new-style classes.

Thanks for the very quick review! So I guess we have switched to python 3 everywhere? I had noticed this line in blender-thumbnailer.py:

Thumbnailer runs with python 2.7 and 3.x.

Perhaps this comment is then the only thing that might need fixing :-)

Revision Contents
Changeset List

PathSize
release/
bin/
2 lines
scripts/
modules/
bl_app_override/
2 lines
6 lines

Diff 13311

View Options

release/bin/blender-thumbnailer.py

Loading...
View Options

release/scripts/modules/bl_app_override/helpers.py

Loading...
View Options

release/scripts/modules/bpy_restrict_state.py

Loading...