Fix T58502: scopes don't work in image editor
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Jan 24 2019, 11:48 AM.

Details

Reviewers

Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)

Maniphest Tasks

T58502: Scopes don't work in image editor

Commits

rBSa4a60358b55d: Fix T58502: scopes don't work in the image editor
rBa4a60358b55d: Fix T58502: scopes don't work in the image editor

Summary

The problem was that the scopes only update if the "Scopes" tab is active.
However, in Blender 2.8 there are no tabs in the image editor anymore.

We might want to check if the corresponding panels are open, but that feels very hacky.
A better approach could be to update the scopes directly before drawing, then it does not matter where they are drawn.

Anyway, let's fix the bug at hand first.

Diff Detail

Repository

rB Blender

Branch

image-scopes (branched from master)

Build Status

Buildable 2767
Build 2767: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Jan 24 2019, 11:48 AM

Harbormaster completed remote builds in B2767: Diff 13322.Jan 24 2019, 11:48 AM

Jacques Lucke (JacquesLucke) added a task: T58502: Scopes don't work in image editor.Jan 24 2019, 11:49 AM

Computing scopes can be very slow, doing it always when the sidebar is open too much of a performance problem.

Instead we should put scopes in their own category again.

This revision now requires changes to proceed.Jan 24 2019, 11:58 AM

Ok, so we'd have to bring back tabs in the image editor again?
Or just check if the panel and subpanels are open for now?

Bring back the tabs / category. The support is there already, it's just a matter of changing bl_category in the Python code. The different scopes panels can be split up again as well then, instead of using subpanels.