Page MenuHome
Differential D4247

bring back possibility to override camera per view
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jan 24 2019, 12:54 PM.

Details

Reviewers
William Reynish (billreynish)
Brecht Van Lommel (brecht)
Maniphest Tasks
T60756: Several Cameras to different viewports
Commits
rBS6100dc6a202c: bring back possibility to override camera per view
rB6100dc6a202c: bring back possibility to override camera per view
Summary

this can now be found in the sidebar View panel

  • this uses existing 'lock_camera_and_layers' but renames the property to 'use_local_camera'
  • uses RNA_def_property_boolean_negative_sdna to flip the value
  • remove the local view code in rna_SpaceView3D_lock_camera_and_layers_set
  • update Python code
  • update Addons code will be separate commit

Fixes T60756

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Jan 24 2019, 12:54 PM
Harbormaster completed remote builds in B2768: Diff 13324.Jan 24 2019, 12:55 PM
Brecht Van Lommel (brecht) requested changes to this revision.Jan 24 2019, 1:07 PM

Please

  • Rename the property to use_local_camera
  • Use RNA_def_property_boolean_sdna to flip the value
  • Remove the local view code in rna_SpaceView3D_lock_camera_and_layers_set
  • Update Python and addons code.

We should not leave things in a halfway state.

This revision now requires changes to proceed.Jan 24 2019, 1:07 PM
Philipp Oeser (lichtwerk) updated this revision to Diff 13333.Jan 24 2019, 5:01 PM
  • Rename the property to use_local_camera
  • Use RNA_def_property_boolean_negative_sdna to flip the value
  • Remove the local view code in rna_SpaceView3D_lock_camera_and_layers_set
  • Update Python code (Addons will be seperate... tomorrow)
Harbormaster completed remote builds in B2774: Diff 13333.Jan 24 2019, 5:01 PM
Philipp Oeser (lichtwerk) added a comment.Jan 24 2019, 5:03 PM

note: unsure about the cycles change (seems to have no effect if I keep this flipped...?)

Brecht Van Lommel (brecht) accepted this revision.Jan 24 2019, 5:03 PM
This revision is now accepted and ready to land.Jan 24 2019, 5:03 PM
Philipp Oeser (lichtwerk) edited the summary of this revision. (Show Details)Jan 24 2019, 5:06 PM
Brecht Van Lommel (brecht) added a comment.Jan 24 2019, 5:13 PM

note: unsure about the cycles change (seems to have no effect if I keep this flipped...?)

The code looks correct and it seems to work correctly for me.

source/blender/makesrna/intern/rna_space.c
3181

Actually this line to define an icon can be removed, just a checkbox in the UI is sufficient.

Closed by commit rB6100dc6a202c: bring back possibility to override camera per view (authored by Philipp Oeser (lichtwerk)). · Explain WhyJan 24 2019, 5:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
intern/
cycles/
blender/
4 lines
release/
scripts/
startup/
bl_operators/
2 lines
bl_ui/
5 lines
source/
blender/
makesrna/
intern/
33 lines

Diff 13335

View Options

intern/cycles/blender/blender_camera.cpp

Loading...
View Options

release/scripts/startup/bl_operators/object.py

Loading...
View Options

release/scripts/startup/bl_ui/space_view3d.py

Loading...
View Options

source/blender/makesrna/intern/rna_space.c

Loading...