Page MenuHome
Differential D4248

Fix T60816: Specify subtype for plane_co in mesh.bisect operator
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Jan 24 2019, 3:16 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Campbell Barton (campbellbarton)
Commits
rBS6b5416909ef4: Fix T60816: Specify subtype for some properties of mesh operators
rB6b5416909ef4: Fix T60816: Specify subtype for some properties of mesh operators
Summary

I hesitate to commit this directly, because the same issue probably exists
in many other operators.

There are three possible solutions:

  1. Don't care, leave everything as is.
  2. Gradually fix all the instances of this problem.
  3. Fix all (most) of the instances of this problem at once.

What should we do?

Diff Detail

Repository
rB Blender
Branch
bisect-prop-unit (branched from master)
Build Status
Buildable 2772
Build 2772: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) created this revision.Jan 24 2019, 3:16 PM
Harbormaster completed remote builds in B2772: Diff 13330.Jan 24 2019, 3:16 PM
Brecht Van Lommel (brecht) added a comment.EditedJan 24 2019, 3:29 PM

RNA_def_float_vector_xyz is used for this purpose usually.

Fixing all is probably not too much work, I think there's only a handful. The axis/normal/scale and mask/image/clip/seq/uvedit stuff does not need units.

brecht@ws-reaper blender2.7 blender$ grep -r "RNA_def_float_vector(" editors/
editors/curve/editcurve.c:	RNA_def_float_vector(ot->srna, "axis", 3, NULL, -1.0f, 1.0f, "Axis", "Axis in global view space", -1.0f, 1.0f);
editors/mask/mask_select.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/mask/mask_add.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/mask/mask_add.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/mask/mask_add.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/space_image/image_ops.c:	RNA_def_float_vector(ot->srna, "offset", 2, NULL, -FLT_MAX, FLT_MAX,
editors/space_image/image_ops.c:	prop = RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/space_image/image_ops.c:	prop = RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/transform/transform_ops.c:			prop = RNA_def_float_vector(ot->srna, "snap_point", 3, NULL, -FLT_MAX, FLT_MAX, "Point", "", -FLT_MAX, FLT_MAX);
editors/transform/transform_ops.c:				prop = RNA_def_float_vector(ot->srna, "snap_normal", 3, NULL, -FLT_MAX, FLT_MAX, "Normal", "", -FLT_MAX, FLT_MAX);
editors/transform/transform_ops.c:	RNA_def_float_vector(ot->srna, "value", 3, VecOne, -FLT_MAX, FLT_MAX, "Scale", "", -FLT_MAX, FLT_MAX);
editors/transform/transform_ops.c:	RNA_def_float_vector(ot->srna, "value", 3, VecOne, -FLT_MAX, FLT_MAX, "Scale", "", -FLT_MAX, FLT_MAX);
editors/transform/transform_ops.c:	RNA_def_float_vector(ot->srna, "value", 4, NULL, -FLT_MAX, FLT_MAX, "Values", "", -FLT_MAX, FLT_MAX);
editors/sculpt_paint/paint_image.c:	RNA_def_float_vector(ot->srna, "delta", 2, NULL, -FLT_MAX, FLT_MAX, "Delta", "Delta offset of clone image in 0.0..1.0 coordinates", -1.0f, 1.0f);
editors/space_clip/tracking_ops.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/space_clip/tracking_ops.c:	RNA_def_float_vector(ot->srna, "offset", 2, NULL, -FLT_MAX, FLT_MAX,
editors/space_clip/tracking_select.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/space_clip/clip_graph_ops.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/space_clip/clip_ops.c:	RNA_def_float_vector(ot->srna, "offset", 2, NULL, -FLT_MAX, FLT_MAX,
editors/space_clip/clip_ops.c:	prop = RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX, "Location",
editors/space_clip/clip_ops.c:	prop = RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX, "Location",
editors/space_clip/clip_ops.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX, "Location",
editors/space_clip/clip_dopesheet_ops.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/space_sequencer/sequencer_add.c:	RNA_def_float_vector(ot->srna, "color", 3, NULL, 0.0f, 1.0f, "Color",
editors/uvedit/uvedit_ops.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/uvedit/uvedit_ops.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/uvedit/uvedit_ops.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX,
editors/uvedit/uvedit_ops.c:	RNA_def_float_vector(ot->srna, "location", 2, NULL, -FLT_MAX, FLT_MAX, "Location",
editors/mesh/editmesh_extrude_spin.c:	RNA_def_float_vector(ot->srna, "center", 3, NULL, -1e12f, 1e12f,
editors/mesh/editmesh_extrude_spin.c:	RNA_def_float_vector(ot->srna, "axis", 3, NULL, -1.0f, 1.0f, "Axis", "Axis in global view space", -1.0f, 1.0f);
editors/mesh/editmesh_bisect.c:	prop = RNA_def_float_vector(ot->srna, "plane_co", 3, NULL, -1e12f, 1e12f,
editors/mesh/editmesh_bisect.c:	prop = RNA_def_float_vector(ot->srna, "plane_no", 3, NULL, -1.0f, 1.0f,
editors/mesh/editmesh_extrude_screw.c:	RNA_def_float_vector(ot->srna, "center", 3, NULL, -1e12f, 1e12f,
editors/mesh/editmesh_extrude_screw.c:	RNA_def_float_vector(ot->srna, "axis", 3, NULL, -1.0f, 1.0f,
Jacques Lucke (JacquesLucke) added a comment.Jan 24 2019, 3:34 PM

Ok, I'll fix the instances of the problem I can find.

Jacques Lucke (JacquesLucke) updated this revision to Diff 13332.Jan 24 2019, 3:49 PM
  • fix more instances of the same problem

I have to admit, there were much fewer instances of this problem than I expected.

I found that the guide_origin property does not seem to be used at all.
Maybe it should be removed?

Harbormaster completed remote builds in B2773: Diff 13332.Jan 24 2019, 3:49 PM
Brecht Van Lommel (brecht) accepted this revision.Jan 24 2019, 4:45 PM

Yes, I think guide_origin can be removed.

This revision is now accepted and ready to land.Jan 24 2019, 4:45 PM
Jacques Lucke (JacquesLucke) mentioned this in T60816: Bisect uses meters for the plane point.Jan 24 2019, 5:04 PM
Closed by commit rB6b5416909ef4: Fix T60816: Specify subtype for some properties of mesh operators (authored by Jacques Lucke (JacquesLucke)). · Explain WhyJan 24 2019, 5:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
mesh/
2 lines

Diff 13330

View Options

source/blender/editors/mesh/editmesh_bisect.c

Loading...