Page MenuHome
Differential D4250

Let ui_but_free free but->search_arg.
ClosedPublic
Actions

Authored by matc (matc) on Jan 24 2019, 8:49 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Maniphest Tasks
T60815: Drag and drop causes null pointer exception
Commits
rBSda1350acdcb4: Fix T60815: drag & drop crash when search menu is opened immediately after.
rBda1350acdcb4: Fix T60815: drag & drop crash when search menu is opened immediately after.
Summary

Prevents ui_but_free from freeing NULL. And fixes T60815.

Diff Detail

Repository
rB Blender

Event Timeline

matc (matc) created this revision.Jan 24 2019, 8:49 PM
matc (matc) updated this revision to Diff 13340.Jan 24 2019, 8:54 PM

Generous BLI_assert to prevent losing a pointer to but->search_arg that would need to be freed.

matc (matc) updated this revision to Diff 14270.Mar 19 2019, 12:17 AM

update to master, freeing but->search_arg without checking for but->editstr

matc (matc) mentioned this in T60815: Drag and drop causes null pointer exception.Mar 19 2019, 12:20 AM
Brecht Van Lommel (brecht) accepted this revision.Mar 20 2019, 7:45 PM
This revision is now accepted and ready to land.Mar 20 2019, 7:45 PM
Closed by commit rBda1350acdcb4: Fix T60815: drag & drop crash when search menu is opened immediately after. (authored by Brecht Van Lommel (brecht)). · Explain WhyMar 20 2019, 7:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
include/
2 lines
interface/
11 lines
3 lines
3 lines
4 lines
space_node/
2 lines

Diff 14328

View Options

source/blender/editors/include/UI_interface.h

Loading...
View Options

source/blender/editors/interface/interface.c

Loading...
View Options

source/blender/editors/interface/interface_handlers.c

Loading...
View Options

source/blender/editors/interface/interface_layout.c

Loading...
View Options

source/blender/editors/interface/interface_templates.c

Loading...
View Options

source/blender/editors/space_node/node_select.c

Loading...