Units for Cycles properties
ClosedPublic
Actions

Authored by Robert Guetzkow (rjg) on Jan 25 2019, 11:37 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)
William Reynish (billreynish)
Brecht Van Lommel (brecht)

Commits

Summary

This patch adds units to the Cycles properties as requested in T60824.

I've fixed some inconsistent quotation marks in the file as well.

Looks good to me

This revision is now accepted and ready to land.Jan 25 2019, 11:53 PM

intern/cycles/blender/addon/properties.py
603	This is a factor relative to the image size, not in pixels.
617	This is a length, not in pixels.

This revision now requires changes to proceed.Jan 26 2019, 12:03 AM

You're right, I was following the remarks of T60824 without checking if the subtype and unit actually matches.

So removing the subtype from camera_cull_margin and make distance_cull_margin a length?

The camera cull margin is now of subtype FACTOR and the cull distance of unit LENGTH.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 26 2019, 3:55 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

intern/

cycles/

blender/

addon/

17 lines