Page MenuHome
Differential D4259

Fix T60849: Adding poll method for quick effects operators
ClosedPublic
Actions

Authored by matc (matc) on Jan 26 2019, 9:24 AM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Brecht Van Lommel (brecht)
Maniphest Tasks
T60849: ctrl+Z closes the whole blender
Commits
rBS2cc303700b65: Fix: Add poll methods for quick effects operators
rB2cc303700b65: Fix: Add poll methods for quick effects operators
Summary

Quick Explode, Smoke and Fluid are not working properly when executed in edit mode. Quick Fur happens to be working in edit mode too.

Fixes T60849

Diff Detail

Event Timeline

matc (matc) created this revision.Jan 26 2019, 9:24 AM
matc (matc) edited the summary of this revision. (Show Details)
matc (matc) added a task: T60849: ctrl+Z closes the whole blender.
Jacques Lucke (JacquesLucke) requested changes to this revision.Mar 7 2019, 3:16 PM
Jacques Lucke (JacquesLucke) added a reviewer: Jacques Lucke (JacquesLucke).
Jacques Lucke (JacquesLucke) added a subscriber: Jacques Lucke (JacquesLucke).

Next time you provide a patch, please add at least one of the core developers (or original author) as reviewer. Otherwise it is easy to oversee such patches..

release/scripts/startup/bl_operators/object_quick_effects.py
49

This base class should not inherit from bpy.types.Operator. Better let the subclasses inherit from two classes.

matc (matc) updated this revision to Diff 14081.Mar 8 2019, 4:32 PM

QuickFur and QuickExplode are currently working in edit mode. But users will only see the results once they leave edit mode.

QuickSmoke fails to create a "Smoke Domain" object while in edit mode.

QuickFluid triggers a bpy.ops.object.shade_smooth.poll() that fails in edit mode.

Should all four be limited to object mode only?

matc (matc) marked an inline comment as done.Mar 8 2019, 4:33 PM
Jacques Lucke (JacquesLucke) added a reviewer: Brecht Van Lommel (brecht).Mar 8 2019, 4:43 PM

Yes, I think it would be good to limit all these operators to object mode.

matc (matc) updated this revision to Diff 14084.Mar 8 2019, 4:54 PM

Limiting all quick effect operators to object mode.

Jacques Lucke (JacquesLucke) added a comment.Mar 8 2019, 4:59 PM

The name QuickObjectMode feels a bit weird. ObjectModeOperator is probably more descriptive.
Other than that, looks good.

matc (matc) updated this revision to Diff 14086.Mar 8 2019, 5:09 PM

Renamed to ObjectModeOperator

Jacques Lucke (JacquesLucke) accepted this revision.Mar 19 2019, 5:15 PM
This revision is now accepted and ready to land.Mar 19 2019, 5:15 PM
Closed by commit rB2cc303700b65: Fix: Add poll methods for quick effects operators (authored by matc (matc), committed by Jacques Lucke (JacquesLucke)). · Explain WhyMar 19 2019, 5:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_operators/
14 lines

Diff 14084

View Options

release/scripts/startup/bl_operators/object_quick_effects.py

Loading...