Differential D4266

Changing Units
ClosedPublic
Actions

Authored by Scott Spadea (scottspadea) on Jan 27 2019, 8:25 PM.

Details

Reviewers

Jacques Lucke (JacquesLucke)

Commits

rBS534891997a6f: Fix: use pixel as unit for some properties
rB534891997a6f: Fix: use pixel as unit for some properties

Summary

Changed smooth_stroke_radius and bokeh_max_size properties to Pixel units.

Diff Detail

Repository: rB Blender

Event Timeline

Scott Spadea (scottspadea) created this revision.Jan 27 2019, 8:25 PM

Thanks, but I can't figure out what unit the Bloom Radius property is in. Doesn't seem to be pixels. @Clément Foucault (fclem): Can you clarify? Thanks

Scott Spadea (scottspadea) edited the summary of this revision. (Show Details)Jan 27 2019, 8:54 PM

Removed changes to bloom_radius, because unsure if its unit should be pixels.

Will check again if the others are right tomorrow and merge it then.

Thanks for the patch :)

This revision was not accepted when it landed; it landed in state Needs Review.Jan 28 2019, 10:51 AM

Closed by commit rB534891997a6f: Fix: use pixel as unit for some properties (authored by Scott Spadea (scottspadea), committed by Jacques Lucke (JacquesLucke)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

source/

blender/

makesrna/

intern/

rna_brush.c

2 lines

rna_scene.c

4 lines

Diff 13376

View Options

source/blender/makesrna/intern/rna_brush.c