Page MenuHome
Differential D4269

Clamp value in sheen calculation to fix fireflies.
ClosedPublic
Actions

Authored by Alexander Court (spiegelball) on Jan 28 2019, 1:31 PM.

Details

Reviewers
Clément Foucault (fclem)
Maniphest Tasks
T59784: Eevee rendering "fireflies"
Commits
rBS253ff57617a9: Clamp value in sheen calculation to fix fireflies.
rB253ff57617a9: Clamp value in sheen calculation to fix fireflies.
Summary

Fixes T59784.

Diff Detail

Repository
rB Blender

Event Timeline

Alexander Court (spiegelball) created this revision.Jan 28 2019, 1:31 PM
Harbormaster completed remote builds in B2784: Diff 13386.Jan 28 2019, 1:31 PM
Brecht Van Lommel (brecht) added a reviewer: Clément Foucault (fclem).Jan 28 2019, 1:47 PM
Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

It seems better to fix the NaNs in the code that generates the normal?

source/blender/gpu/shaders/gpu_shader_material.glsl
1092

Temporal -> Temporary

Clément Foucault (fclem) added a comment.Jan 28 2019, 3:54 PM

I have no problem with that. The meshes can gave issues that trigger precision issues in normal calculation and we have similar checks for the other bsdfs.

source/blender/gpu/shaders/gpu_shader_material.glsl
1093

The following fit is only valid for N.V in [0..1] range. So it might even be better to clamp(f, 0.0, 1.0) instead.

Alexander Court (spiegelball) updated this revision to Diff 13404.Jan 29 2019, 9:29 AM

Changed clamp range and corrected spelling.

Harbormaster completed remote builds in B2792: Diff 13404.Jan 29 2019, 9:29 AM
Alexander Court (spiegelball) added a comment.Feb 18 2019, 11:39 AM

Hey guys, is there anything I can do on this patch to get it approved? So many reports on those fireflies are coming in.

Clément Foucault (fclem) accepted this revision.Feb 18 2019, 1:48 PM
This revision is now accepted and ready to land.Feb 18 2019, 1:48 PM
Alexander Court (spiegelball) added a comment.Feb 18 2019, 1:53 PM

Thanks @Clément Foucault (fclem)! Do I have to do something, it says "ready to land"?

Closed by commit rB253ff57617a9: Clamp value in sheen calculation to fix fireflies. (authored by Alexander Court (spiegelball), committed by Clément Foucault (fclem)). · Explain WhyFeb 18 2019, 2:05 PM
This revision was automatically updated to reflect the committed changes.
Giampaolo (joaulo) added a subscriber: Giampaolo (joaulo).Mar 22 2021, 12:01 PM

Revision Contents
Changeset List

PathSize
source/
blender/
gpu/
shaders/
2 lines

Diff 13722

View Options

source/blender/gpu/shaders/gpu_shader_material.glsl

Loading...