Paths

Table of Contentst

Differential D4277

Logging: changed printf statements to clog
Needs ReviewPublic
Actions

Authored by Andrew Williams (sobakasu) on Jan 29 2019, 4:59 AM.

Tags

None

Subscribers

None

Details

Reviewers

Campbell Barton (campbellbarton)

Commits

rB68ae1f4958e2: Fix CLOG_STR_AT_SEVERITY macro

Diff Detail

Repository: rB Blender

Event Timeline

Andrew Williams (sobakasu) created this revision.Jan 29 2019, 4:59 AM

Andrew Williams (sobakasu) marked 2 inline comments as done.Jan 29 2019, 5:13 AM

Andrew Williams (sobakasu) added inline comments.

source/blender/blenkernel/intern/screen.c
631	sorry about this random code change, I got bored
source/blender/imbuf/intern/tiff.c
174	this is my favourite error message

Don't reorder includes (strict defines need to be last, else inlines error on Linux).
Remove logging for command line argument handling (regular printing is appropriate here).
Applied fixes to macros to master (rB68ae1f4958e24906992a3207726c0031de9524b5)

Harbormaster completed remote builds in B2789: Diff 13399.Jan 29 2019, 7:41 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 29 2019, 7:42 AM

Closed by commit rB68ae1f4958e2: Fix CLOG_STR_AT_SEVERITY macro (authored by Campbell Barton (campbellbarton)). · Explain Why

This revision was automatically updated to reflect the committed changes.

Campbell Barton (campbellbarton) mentioned this in rB68ae1f4958e2: Fix CLOG_STR_AT_SEVERITY macro.

Campbell Barton (campbellbarton) reopened this revision.Jan 29 2019, 7:47 AM

Campbell Barton (campbellbarton) added inline comments.

source/blender/blenfont/intern/blf_font.c

Don't re-order headers, it's unrelated to your patch and causes the patch to fail here.

source/blender/gpu/GPU_vertex_buffer.h:117:35: error: conversion from 'long int' to 'uint' {aka 'unsigned int'} may change value [-Werror=conversion]
  return ((a->data - a->data_init) / a->stride);
         ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~
cc1: all warnings being treated as errors

Update diff against master

Harbormaster completed remote builds in B2791: Diff 13402.Jan 29 2019, 7:48 AM

Regarding this patch in general,

Sometimes developers added prints into the code where they could be asserts, eg: This should never happen.
Other times the messages should be shown to the user via reports, eg: render_result_exr_file_read_path.

There are many urgent bugs to fix in 2.8x, while some of the edits in this patch can be applied as-is.

There are other areas where we should reconsider error messages (render pipeline for eg).

Campbell Barton (campbellbarton) mentioned this in rB552b2287db86: Logging: Use CLOG for blenkernel.Feb 1 2019, 2:43 AM

Applied nearly all the blenkernel changes rB552b2287db86ed6e77565672fbccff1d553f823f

Use CLOG_ERROR instead of CLOG_FATAL since behavior is slightly different to BLI_assert.

Merge branch 'master' into arcpatch-D4277_1

Harbormaster completed remote builds in B2824: Diff 13460.Feb 1 2019, 2:46 AM

Revision Contents
Changeset List

Path

Size

intern/

clog/

14 lines

source/

blender/

alembic/

1 line

intern/

6 lines

avi/

1 line

intern/

20 lines

blenfont/

1 line

intern/

16 lines

13 lines

blf_font_i18n.c

6 lines

blf_font_win32_compat.c

12 lines

7 lines

blenkernel/

intern/

22 lines

9 lines

9 lines

8 lines

53 lines

9 lines

10 lines

1 line

6 lines

11 lines

4 lines

7 lines

cdderivedmesh.c

4 lines

3 lines

6 lines

16 lines

6 lines

25 lines

data_transfer.c

5 lines

9 lines

40 lines

22 lines

13 lines

8 lines

14 lines

6 lines

7 lines

14 lines

18 lines

library_remap.c

10 lines

26 lines

mask_rasterize.c

5 lines

8 lines

20 lines

mesh_evaluate.c

8 lines

9 lines

mesh_validate.c

79 lines

4 lines

8 lines

11 lines

17 lines

8 lines

12 lines

38 lines

28 lines

imbuf/

1 line

intern/

10 lines

56 lines

modifiers/

1 line

intern/

3 lines

MOD_fluidsim_util.c

9 lines

5 lines

4 lines

MOD_weightvgproximity.c

6 lines

python/

generic/

1 line

bpy_internal_import.c

8 lines

gpu/

1 line

gpu_py_matrix.c

11 lines

intern/

6 lines

bpy_app_translations.c

4 lines

25 lines

bpy_interface.c

12 lines

render/

1 line

intern/

source/

16 lines

render_result.c

26 lines

windowmanager/

gizmo/

intern/

wm_gizmo_type.c

7 lines

intern/

6 lines

wm_event_system.c

4 lines

37 lines

wm_files_link.c

5 lines

wm_operator_type.c

2 lines

creator/

3 lines

133 lines

Diff 13398

intern/clog/CLG_log.h

Loading...

source/blender/alembic/CMakeLists.txt

Loading...

source/blender/alembic/intern/abc_curves.cc

Loading...

source/blender/avi/CMakeLists.txt

Loading...

source/blender/avi/intern/avi.c

Loading...

source/blender/blenfont/CMakeLists.txt

Loading...

source/blender/blenfont/intern/blf.c

Loading...

source/blender/blenfont/intern/blf_font.c

Loading...

source/blender/blenfont/intern/blf_font_i18n.c

Loading...

source/blender/blenfont/intern/blf_font_win32_compat.c

Loading...

source/blender/blenfont/intern/blf_thumbs.c

Loading...

source/blender/blenkernel/intern/DerivedMesh.c

Loading...

source/blender/blenkernel/intern/action.c

Loading...

source/blender/blenkernel/intern/addon.c

Loading...

source/blender/blenkernel/intern/anim.c

Loading...

source/blender/blenkernel/intern/anim_sys.c

Loading...

source/blender/blenkernel/intern/appdir.c

Loading...

source/blender/blenkernel/intern/armature.c

Loading...

source/blender/blenkernel/intern/blender.c

Loading...

source/blender/blenkernel/intern/blendfile.c

Loading...

source/blender/blenkernel/intern/bpath.c

Loading...

source/blender/blenkernel/intern/brush.c

Loading...

source/blender/blenkernel/intern/bvhutils.c

Loading...

source/blender/blenkernel/intern/cdderivedmesh.c

Loading...

source/blender/blenkernel/intern/cloth.c

Loading...

source/blender/blenkernel/intern/constraint.c

Loading...

source/blender/blenkernel/intern/context.c

Loading...

source/blender/blenkernel/intern/curve.c

Loading...

source/blender/blenkernel/intern/customdata.c

Loading...

source/blender/blenkernel/intern/data_transfer.c

Loading...

source/blender/blenkernel/intern/dynamicpaint.c

Loading...

source/blender/blenkernel/intern/fcurve.c

Loading...

source/blender/blenkernel/intern/fmodifier.c

Loading...

source/blender/blenkernel/intern/font.c

Loading...

source/blender/blenkernel/intern/gpencil.c

Loading...

source/blender/blenkernel/intern/icons.c

Loading...

source/blender/blenkernel/intern/idprop.c

Loading...

source/blender/blenkernel/intern/image.c

Loading...

source/blender/blenkernel/intern/ipo.c

Loading...

source/blender/blenkernel/intern/library.c

Loading...

source/blender/blenkernel/intern/library_remap.c

Loading...

source/blender/blenkernel/intern/mask.c

Loading...

source/blender/blenkernel/intern/mask_rasterize.c

Loading...

source/blender/blenkernel/intern/material.c

Loading...

source/blender/blenkernel/intern/mesh_convert.c

Loading...

source/blender/blenkernel/intern/mesh_evaluate.c

Loading...

source/blender/blenkernel/intern/mesh_remap.c

Loading...

source/blender/blenkernel/intern/mesh_validate.c

Loading...

source/blender/blenkernel/intern/modifier.c

Loading...

source/blender/blenkernel/intern/nla.c

Loading...

source/blender/blenkernel/intern/node.c

Loading...

source/blender/blenkernel/intern/object.c

Loading...

source/blender/blenkernel/intern/pointcache.c

Loading...

source/blender/blenkernel/intern/rigidbody.c

Loading...

source/blender/blenkernel/intern/screen.c

Loading...

source/blender/blenkernel/intern/softbody.c

Loading...

source/blender/imbuf/CMakeLists.txt

Loading...

source/blender/imbuf/intern/targa.c

Loading...

source/blender/imbuf/intern/tiff.c

Loading...

source/blender/modifiers/CMakeLists.txt

Loading...

source/blender/modifiers/intern/MOD_fluidsim.c

Loading...

source/blender/modifiers/intern/MOD_fluidsim_util.c

Loading...

source/blender/modifiers/intern/MOD_screw.c

Loading...

source/blender/modifiers/intern/MOD_surface.c

Loading...

source/blender/modifiers/intern/MOD_weightvgproximity.c

Loading...

source/blender/python/generic/CMakeLists.txt

Loading...

source/blender/python/generic/bpy_internal_import.c

Loading...

source/blender/python/gpu/CMakeLists.txt

Loading...

source/blender/python/gpu/gpu_py_matrix.c

Loading...

source/blender/python/intern/bpy.c

Loading...

source/blender/python/intern/bpy_app_translations.c

Loading...

source/blender/python/intern/bpy_driver.c

Loading...

source/blender/python/intern/bpy_interface.c

Loading...

source/blender/render/CMakeLists.txt

Loading...

source/blender/render/intern/source/pipeline.c

Loading...

source/blender/render/intern/source/render_result.c

Loading...

source/blender/windowmanager/gizmo/intern/wm_gizmo_type.c

Loading...

source/blender/windowmanager/intern/wm_dragdrop.c

Loading...

source/blender/windowmanager/intern/wm_event_system.c

Loading...

source/blender/windowmanager/intern/wm_files.c

Loading...

source/blender/windowmanager/intern/wm_files_link.c

Loading...

source/blender/windowmanager/intern/wm_operator_type.c

Loading...

source/creator/creator.c

Loading...

source/creator/creator_args.c

Loading...